-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Introduce network service discovery #349
Conversation
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #349. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
cibot: @niley7464, Tizen.web/ImageClassificationOffloadingService/src/main.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niley7464, 💯 All CI checkers are successfully verified. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niley7464, 💯 All CI checkers are successfully verified. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niley7464, 💯 All CI checkers are successfully verified. Thanks.
cibot: @niley7464, The last line of a text file must have a newline character. Please append a new line at the end of the line in Tizen.web/ImageClassificationOffloading/css/style.css. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niley7464, 💯 All CI checkers are successfully verified. Thanks.
This patch introduces network service discovery to Tizen service. NSD will be used to set ip and port automatically. Signed-off-by: Yelin Jeong <[email protected]>
This patch removes input text box and use nsd service when create offloading pipeline. Signed-off-by: Yelin Jeong <[email protected]>
96e85e8
to
5895fea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niley7464, 💯 All CI checkers are successfully verified. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This patch introduces network service discovery to Tizen service.
NSD will be used to set ip and port automatically.