Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tizen] Add example app showing ml-service and rpk updates #352

Merged
merged 2 commits into from
Jul 11, 2024
Merged

[Tizen] Add example app showing ml-service and rpk updates #352

merged 2 commits into from
Jul 11, 2024

Conversation

anyj0527
Copy link
Member

@anyj0527 anyj0527 commented Jul 5, 2024

  • Add a simple app showing how to use API ml_service_new and ml_service_request.
  • This app also demonstrate that how rpk updates can be used in AI app.

Check the README.md

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Jul 5, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #352. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link
Collaborator

taos-ci commented Jul 5, 2024

:octocat: cibot: @anyj0527, Tizen.native/ml-service-example/sum_and_add_app/inc/sum_and_add.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@anyj0527 anyj0527 force-pushed the update-ml-svc-example branch from 552d3c3 to 8f0cf4b Compare July 5, 2024 06:52
taos-ci
taos-ci approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anyj0527, 💯 All CI checkers are successfully verified. Thanks.

again4you
again4you approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@again4you again4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for trivial issues, this PR is good material for newbies. 👍

Tizen.native/ml-service-example/sum_and_add_app/src/sum_and_add.c Outdated Show resolved Hide resolved
@anyj0527 anyj0527 force-pushed the update-ml-svc-example branch from 8f0cf4b to 71e08fc Compare July 5, 2024 07:51
taos-ci
taos-ci approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anyj0527, 💯 All CI checkers are successfully verified. Thanks.

anyj0527 added 2 commits July 9, 2024 13:35
@anyj0527
[ml-service] Add rpk pacakges for new example
a5eb901 
- Add rpk packages for new example.
- Each rpk is packaged into `org.resource.model.sum_and_add-1.0.0.rpk` and `org.resource.model.sum_and_add-2.0.0.rpk`

Signed-off-by: Yongjoo Ahn <[email protected]>
@anyj0527
[Tizen] Add example app showing ml-service and rpk updates
e720d98 
- Add a simple app showing how to use API `ml_service_new` and
  `ml_service_request`.
- This app also demonstrate that how rpk updates can be used in AI app.

Signed-off-by: Yongjoo Ahn <[email protected]>
@anyj0527 anyj0527 force-pushed the update-ml-svc-example branch from 71e08fc to e720d98 Compare July 9, 2024 04:36
taos-ci
taos-ci approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anyj0527, 💯 All CI checkers are successfully verified. Thanks.

niley7464
niley7464 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@niley7464 niley7464 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has become easier to understand ml-service and rpk updates 😀
LGTM!

@anyj0527 anyj0527 mentioned this pull request Jul 9, 2024
Merged
@myungjoo myungjoo merged commit 3b023f7 into nnstreamer:main Jul 11, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taos-ci taos-ci taos-ci approved these changes

@niley7464 niley7464 niley7464 approved these changes

@again4you again4you again4you approved these changes

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anyj0527 @taos-ci @again4you @niley7464 @myungjoo