Skip to content

Commit

Permalink
[css-contain] Editorial tweak in introduction
Browse files Browse the repository at this point in the history
Closes w3c#4466
  • Loading branch information
frivoal committed Nov 11, 2019
1 parent bc14435 commit 1c20386
Show file tree
Hide file tree
Showing 6 changed files with 170 additions and 2 deletions.
3 changes: 2 additions & 1 deletion css-contain-1/Overview.bs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ Introduction</h2>

There are various heuristics that can be used to guess when a given sub-tree is independent of the rest of the page in some manner,
but they're fragile,
so innocuous changes to a page may inadvertently make it flunk the heuristics and fall into a slow mode.
so innocuous changes to a page may inadvertently make it fail such heuristic tests,
causing rendering to fall into a slow code path.
There are also many things that would be good to isolate which are difficult or impossible to detect in a heuristic manner.

To alleviate these problems
Expand Down
72 changes: 72 additions & 0 deletions css-contain-1/issues-2019-10-pr.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>CSS Contain Level 1 Disposition of Comments for 2019-10-15 PR</title>
<style>
.a { background: lightgreen }
.d { background: lightblue }
.r { background: orange }
.fo { background: red }
.open { border: solid red; padding: 0.2em; }
:target { box-shadow: 0.25em 0.25em 0.25em; }
</style>

<h1>CSS Contain Level 1 Disposition of Comments for 2019-10-15 PR</h1>

<p>Review document: <a href="https://www.w3.org/TR/2019/PR-css-contain-1-20191015/">https://www.w3.org/TR/2019/PR-css-contain-1-20191015/</a>

<p>Editor's draft: <a href="http://dev.w3.org/csswg/css-contain-1/">http://dev.w3.org/csswg/css-contain-1/</a>

<p>The following color coding convention is used for comments:</p>

<ul>
<li class="a">Accepted or Rejected and positive response
<li class="r">Rejected and no response
<li class="fo">Rejected and negative response
<li class="d">Deferred
<li class="oi">Out-of-Scope or Invalid and not verified
</ul>

<p class=open>Open issues are marked like this</p>

<p>An issue can be closed as <code>Accepted</code>, <code>OutOfScope</code>,
<code>Invalid</code>, <code>Rejected</code>, or <code>Retracted</code>.
<code>Verified</code> indicates commentor's acceptance of the response.</p>
<pre class='a' id='issue-1'>
Issue 1. <a href='#issue-1'>#</a>
Summary: Suggest Rephrasing in Introduction
From: Chris Needham
Comment: <a href='https://github.com/w3c/csswg-drafts/issues/4466'>https://github.com/w3c/csswg-drafts/issues/4466</a>
Response: <a href='https://github.com/w3c/csswg-drafts/pull/3898'>https://github.com/w3c/csswg-drafts/pull/3898</a>
Closed: Accepted
Resolved: Editorial</pre>
<script>
(function () {
var sheet = document.styleSheets[0];
function addCheckbox(className) {
var element = document.querySelector('*.' + className);
var label = document.createElement('label');
label.innerHTML = element.innerHTML;
element.innerHTML = null;
var check = document.createElement('input');
check.type = 'checkbox';
if (className == 'open') {
check.checked = false;
sheet.insertRule('pre:not(.open)' + '{}', sheet.cssRules.length);
check.onchange = function (e) {
rule.style.display = this.checked ? 'none' : 'block';
}
}
else {
check.checked = true;
sheet.insertRule('pre.' + className + '{}', sheet.cssRules.length);
check.onchange = function (e) {
rule.style.display = this.checked ? 'block' : 'none';
}
}
var rule = sheet.cssRules[sheet.cssRules.length - 1];
element.appendChild(label);
label.insertBefore(check, label.firstChild);
}
['a', 'd', 'fo', 'oi', 'r', 'open'].forEach(addCheckbox);
}());
</script>
11 changes: 11 additions & 0 deletions css-contain-1/issues-2019-10-pr.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Draft: https://www.w3.org/TR/2019/PR-css-contain-1-20191015/
Title: CSS Contain Level 1

----
Issue 1.
Summary: Suggest Rephrasing in Introduction
From: Chris Needham
Comment: https://github.com/w3c/csswg-drafts/issues/4466
Response: https://github.com/w3c/csswg-drafts/pull/3898
Closed: Accepted
Resolved: Editorial
3 changes: 2 additions & 1 deletion css-contain-2/Overview.bs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ Introduction</h2>

There are various heuristics that can be used to guess when a given sub-tree is independent of the rest of the page in some manner,
but they're fragile,
so innocuous changes to a page may inadvertently make it flunk the heuristics and fall into a slow mode.
so innocuous changes to a page may inadvertently make it fail such heuristic tests,
causing rendering to fall into a slow code path.
There are also many things that would be good to isolate which are difficult or impossible to detect in a heuristic manner.

To alleviate these problems
Expand Down
72 changes: 72 additions & 0 deletions css-contain-2/issues-2019-10-pr.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>CSS Contain Level 2 Disposition of Comments for 2019-10-15 WD</title>
<style>
.a { background: lightgreen }
.d { background: lightblue }
.r { background: orange }
.fo { background: red }
.open { border: solid red; padding: 0.2em; }
:target { box-shadow: 0.25em 0.25em 0.25em; }
</style>

<h1>CSS Contain Level 2 Disposition of Comments for 2019-10-15 WD</h1>

<p>Review document: <a href="https://www.w3.org/TR/2019/WD-css-contain-2-20191015/">https://www.w3.org/TR/2019/WD-css-contain-2-20191015/</a>

<p>Editor's draft: <a href="http://dev.w3.org/csswg/css-contain-2/">http://dev.w3.org/csswg/css-contain-2/</a>

<p>The following color coding convention is used for comments:</p>

<ul>
<li class="a">Accepted or Rejected and positive response
<li class="r">Rejected and no response
<li class="fo">Rejected and negative response
<li class="d">Deferred
<li class="oi">Out-of-Scope or Invalid and not verified
</ul>

<p class=open>Open issues are marked like this</p>

<p>An issue can be closed as <code>Accepted</code>, <code>OutOfScope</code>,
<code>Invalid</code>, <code>Rejected</code>, or <code>Retracted</code>.
<code>Verified</code> indicates commentor's acceptance of the response.</p>
<pre class='a' id='issue-1'>
Issue 1. <a href='#issue-1'>#</a>
Summary: Suggest Rephrasing in Introduction
From: Chris Needham
Comment: <a href='https://github.com/w3c/csswg-drafts/issues/4466'>https://github.com/w3c/csswg-drafts/issues/4466</a>
Response: <a href='https://github.com/w3c/csswg-drafts/pull/3898'>https://github.com/w3c/csswg-drafts/pull/3898</a>
Closed: Accepted
Resolved: Editorial</pre>
<script>
(function () {
var sheet = document.styleSheets[0];
function addCheckbox(className) {
var element = document.querySelector('*.' + className);
var label = document.createElement('label');
label.innerHTML = element.innerHTML;
element.innerHTML = null;
var check = document.createElement('input');
check.type = 'checkbox';
if (className == 'open') {
check.checked = false;
sheet.insertRule('pre:not(.open)' + '{}', sheet.cssRules.length);
check.onchange = function (e) {
rule.style.display = this.checked ? 'none' : 'block';
}
}
else {
check.checked = true;
sheet.insertRule('pre.' + className + '{}', sheet.cssRules.length);
check.onchange = function (e) {
rule.style.display = this.checked ? 'block' : 'none';
}
}
var rule = sheet.cssRules[sheet.cssRules.length - 1];
element.appendChild(label);
label.insertBefore(check, label.firstChild);
}
['a', 'd', 'fo', 'oi', 'r', 'open'].forEach(addCheckbox);
}());
</script>
11 changes: 11 additions & 0 deletions css-contain-2/issues-2019-10-pr.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Draft: https://www.w3.org/TR/2019/WD-css-contain-2-20191015/
Title: CSS Contain Level 2

----
Issue 1.
Summary: Suggest Rephrasing in Introduction
From: Chris Needham
Comment: https://github.com/w3c/csswg-drafts/issues/4466
Response: https://github.com/w3c/csswg-drafts/pull/3898
Closed: Accepted
Resolved: Editorial

0 comments on commit 1c20386

Please sign in to comment.