Add pre-commit and run on all files.

.github/workflows/build_linux_packages.yml

@@ -108,5 +108,3 @@ jobs:
         with:
           path: ${{ env.CACHE_DIR }}
           key: linux-build-packages-manylinux-v2-${{ github.sha }}
-
-

.github/workflows/build_python_packages.yml

@@ -100,5 +100,3 @@ jobs:
         with:
           path: ${{ env.CACHE_DIR }}
           key: build-python-manylinux-v2-${{ github.sha }}
-
-

.github/workflows/ci.yml

@@ -26,4 +26,3 @@ jobs:
     name: Build Python Packages
     needs: setup
     uses: ./.github/workflows/build_python_packages.yml
-

.github/workflows/nightly_staging_release.yml

@@ -29,7 +29,7 @@ jobs:
       tag_name: ${{ steps.compute_version.outputs.tag_name }}
       release_id: ${{ steps.create_release.outputs.id }}
       release_upload_url: ${{ steps.create_release.outputs.upload_url }}
-      
+
     steps:
       - name: Checking out repository
         uses: actions/checkout@v4
@@ -107,7 +107,7 @@ jobs:
           ls -l linux-x86_64
       - name: Upload Release Assets
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}        
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           gh release upload ${{ needs.setup.outputs.tag_name }} \
               linux-x86_64/*
@@ -135,6 +135,6 @@ jobs:
 
       - name: Mark Release Non Draft
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}        
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           gh release edit ${{ needs.setup.outputs.tag_name }} --draft=false

.pre-commit-config.yaml

@@ -0,0 +1,18 @@
+# See https://pre-commit.com for more information
+# See https://pre-commit.com/hooks.html for more hooks
+repos:
+-   repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v3.2.0
+    hooks:
+    -   id: trailing-whitespace
+    -   id: end-of-file-fixer
+    -   id: check-yaml
+    -   id: check-added-large-files
+-   repo: https://github.com/psf/black
+    rev: 22.10.0
+    hooks:
+    -   id: black
+-   repo: https://github.com/pre-commit/mirrors-clang-format
+    rev: 'v18.1.4'
+    hooks:
+    -   id: clang-format

README.md

@@ -1,6 +1,8 @@
 # TheRock
 The HIP Environment and ROCm Kit - A lightweight open source build system for HIP and ROCm
 
+[![pre-commit](https://img.shields.io/badge/pre--commit-enabled-brightgreen?logo=pre-commit)](https://github.com/pre-commit/pre-commit)
+
 # Install Deps
 
 ## Common

cmake/custom_install_amdgpu_compiler.cmake

@@ -33,7 +33,7 @@ file(
 foreach(_relpath ${LLVM_FILES} ${HIPCC_FILES})
   cmake_path(GET _relpath PARENT_PATH _parent_rel_path)
   file(
-    INSTALL ${STAGING_INSTALL_DIR}/${_relpath} 
+    INSTALL ${STAGING_INSTALL_DIR}/${_relpath}
     DESTINATION ${CMAKE_INSTALL_PREFIX}/${_parent_rel_path}
     USE_SOURCE_PERMISSIONS
   )

cmake/custom_install_amdgpu_runtime.cmake

@@ -30,9 +30,9 @@ list(REMOVE_ITEM LIB_FILES
 foreach(_relpath ${LIB_FILES})
   cmake_path(GET _relpath PARENT_PATH _parent_rel_path)
   file(
-    INSTALL ${STAGING_INSTALL_DIR}/${_relpath} 
+    INSTALL ${STAGING_INSTALL_DIR}/${_relpath}
     DESTINATION ${CMAKE_INSTALL_PREFIX}/${_parent_rel_path}
-    USE_SOURCE_PERMISSIONS    
+    USE_SOURCE_PERMISSIONS
   )
 endforeach()
 
@@ -58,6 +58,6 @@ foreach(_relpath ${LLVM_LIB_FILES})
   file(
     INSTALL ${STAGING_INSTALL_DIR}/llvm/${_relpath}
     DESTINATION ${CMAKE_INSTALL_PREFIX}/${_parent_rel_path}
-    USE_SOURCE_PERMISSIONS    
+    USE_SOURCE_PERMISSIONS
   )
 endforeach()

cmake/custom_install_amdgpu_runtime_dev.cmake

@@ -27,7 +27,7 @@ file(
 foreach(_relpath ${DEV_FILES})
   cmake_path(GET _relpath PARENT_PATH _parent_rel_path)
   file(
-    INSTALL ${STAGING_INSTALL_DIR}/${_relpath} 
+    INSTALL ${STAGING_INSTALL_DIR}/${_relpath}
     DESTINATION ${CMAKE_INSTALL_PREFIX}/${_parent_rel_path}
     USE_SOURCE_PERMISSIONS
   )

cmake/extensions/clr_post.cmake

@@ -7,5 +7,5 @@ therock_set_install_rpath(
     hiprtc
   PATHS
     .
-    llvm/lib    
-)
+    llvm/lib
+)

cmake/extensions/rocr_post.cmake

@@ -6,5 +6,5 @@ therock_set_install_rpath(
     hsa-runtime64
   PATHS
     .
-    llvm/lib    
-)
+    llvm/lib
+)

cmake/therock_external_project_include.cmake

@@ -12,7 +12,7 @@ cmake_language(DEFER CALL therock_post_external_project)
 function(therock_post_external_project)
   if(EXISTS "${THEROCK_SOURCE_DIR}/cmake/extensions/${CMAKE_PROJECT_NAME}_post.cmake")
     message(STATUS "Including project extensions: ${CMAKE_PROJECT_NAME}_post.cmake")
-    # Note that because of the way defer processing works, we include in a 
+    # Note that because of the way defer processing works, we include in a
     # function scope, which usually wouldn't make sense. But since this will
     # by definition be the last thing evaluated, there is nothing to observe
     # the top level scope after this anyway, so it is ok to do here.

cmake/therock_rpath.cmake

@@ -24,4 +24,4 @@ function(therock_set_install_rpath)
   endforeach()
   message(STATUS "Set RPATH ${_rpath} on ${ARG_TARGETS}")
   set_target_properties(${ARG_TARGETS} PROPERTIES INSTALL_RPATH "${_rpath}")
-endfunction()
+endfunction()

python_projects/runtime/setup.py

@@ -34,12 +34,12 @@ def finalize_options(self):
 # Note that setuptools always builds into a "build" directory that
 # is a sibling of setup.py, so we just colonize a sub-directory of that
 # by default.
-CMAKE_BUILD_DIR = Path(os.getenv(
-    "THEROCK_CMAKE_BUILD_DIR", SETUPPY_DIR / "build" / "cmake-build"
-))
-CMAKE_INSTALL_DIR = Path(os.getenv(
-    "THEROCK_CMAKE_INSTALL_DIR", SETUPPY_DIR / "build" / "dist-install"
-))
+CMAKE_BUILD_DIR = Path(
+    os.getenv("THEROCK_CMAKE_BUILD_DIR", SETUPPY_DIR / "build" / "cmake-build")
+)
+CMAKE_INSTALL_DIR = Path(
+    os.getenv("THEROCK_CMAKE_INSTALL_DIR", SETUPPY_DIR / "build" / "dist-install")
+)
 
 with open(SETUPPY_DIR / "README.md", "rt") as f:
     README = f.read()

tests/dlopen-hip.c

@@ -9,7 +9,8 @@ int main(int argc, char **argv) {
   char *lib_path = argv[1];
   int rc;
   void *h = dlopen(lib_path, RTLD_NOW);
-  int(*hipRuntimeGetVersion)(int*) = (int(*)(int*))dlsym(h, "hipRuntimeGetVersion");
+  int (*hipRuntimeGetVersion)(int *) =
+      (int (*)(int *))dlsym(h, "hipRuntimeGetVersion");
   if (!hipRuntimeGetVersion) {
     fprintf(stderr, "ERROR: Could not resolve symbol hipRuntimeGetVersion\n");
     return 1;