Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to rocm 6.3.1. #14

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Bump to rocm 6.3.1. #14

merged 2 commits into from
Jan 18, 2025

Conversation

stellaraccident
Copy link
Contributor

@stellaraccident stellaraccident commented Jan 14, 2025

Key changes:

  • Moved llvm/ -> lib/llvm/
  • libamdhip64 now depends on rocprofiler
  • rccl:
    • switches to clang++ vs hipcc
    • depends on rocprofiler
    • disabled pending further work
  • Drop 6.1 patches
  • Setup rpaths to account for llvm move (required adding some goo for doing project interception in cmake)
  • Move rocr to top-level and eliminate rocm-core-libs

Key changes:

* Moved llvm/ -> lib/llvm/
* libamdhip64 now depends on rocprofiler
* rccl switches to clang++ vs hipcc
* rccl depends on rocprofiler
* Drop 6.1 patches
* Setup rpaths to account for llvm move (required adding some goo for doing project interception in cmake)
* Move rocr to top-level and eliminate rocm-core-libs
@amd-chrissosa
Copy link

Adding @marbre to take a look as well.

Right now focused on reproducing what you have on my Azure vm. Did a full checkout and build of 6.3.1 using the easiest of the workflows and checking in sources directly into TheRock repo, Looks great so far. We should get the CI working once this is checked in. What's the bar for submitting?

README.md Outdated Show resolved Hide resolved
@stellaraccident
Copy link
Contributor Author

I'll land it tomorrow. Just need to dot some I'd I ran out of time for

Copy link
Contributor

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building and sanity check pass:

~/TheRock$ ./build/dlopen-hip install/lib/libamdhip64.so
HIP VERSION: 3938700

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@stellaraccident stellaraccident merged commit 96c0e49 into main Jan 18, 2025
@stellaraccident stellaraccident deleted the rocm-6.3.1 branch January 18, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants