Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VAE spec file for MI300x-QPX-BS1 #123

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Add VAE spec file for MI300x-QPX-BS1 #123

merged 5 commits into from
Feb 21, 2025

Conversation

rkayaith
Copy link

Also updates to the compile and benchmark scripts

  • update VAE flags to match PUNET
  • use real input data when benchmarking VAE

@rkayaith rkayaith requested a review from Max191 February 21, 2025 22:36
Max191
Max191 approved these changes Feb 21, 2025
View reviewed changes
Copy link

@Max191 Max191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one nit!

@rkayaith rkayaith merged commit 9f0edb4 into shared/sdxl_on_main Feb 21, 2025
@rkayaith rkayaith deleted the rahul/sdxl_on_main-vae-tuning branch February 21, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Max191 Max191 Max191 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkayaith @Max191