Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tokenizers in shortfin packages on Linux x86_64. #688

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable tokenizers in shortfin packages on Linux x86_64. #688

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00fa7da
Enable tokenizers in shortfin packages on Linux x86_64.
ScottTodd Dec 12, 2024
4fa0d51
Merge remote-tracking branch 'upstream/main' into shortfin-docker-rust
ScottTodd Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions shortfin/build_tools/build_linux_package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,13 @@ SHORTFIN_ENABLE_TRACING="${SHORTFIN_ENABLE_TRACING:-ON}"

if [[ "${ARCH}" == "x86_64" ]]; then
MANYLINUX_DOCKER_IMAGE="${MANYLINUX_DOCKER_IMAGE:-ghcr.io/nod-ai/manylinux_x86_64@sha256:4acf83343706d1e37252d6001ded3c97a73bc38620580f855b4e65e35ddc5681}"
# Our x86_64 dockerfile contains dependencies needed to build the tokenizer
# library (rust), so enable tokenizers by default on x86_64.
SHORTFIN_ENABLE_TOKENIZERS="${SHORTFIN_ENABLE_TOKENIZERS:-ON}"
else
# TODO: publish a multi-platform manylinux image and include more deps in all platforms (rust, ccache, etc.)
MANYLINUX_DOCKER_IMAGE="${MANYLINUX_DOCKER_IMAGE:-quay.io/pypa/manylinux_2_28_${ARCH}:latest}"
SHORTFIN_ENABLE_TOKENIZERS="${SHORTFIN_ENABLE_TOKENIZERS:-OFF}"
fi

function run_on_host() {
Expand Down Expand Up @@ -74,6 +78,7 @@ function run_on_host() {
-e "OVERRIDE_PYTHON_VERSIONS=${PYTHON_VERSIONS}" \
-e "OUTPUT_DIR=${OUTPUT_DIR}" \
-e "SHORTFIN_ENABLE_TRACING=${SHORTFIN_ENABLE_TRACING}" \
-e "SHORTFIN_ENABLE_TOKENIZERS=${SHORTFIN_ENABLE_TOKENIZERS}" \
${extra_args} \
"${MANYLINUX_DOCKER_IMAGE}" \
-- ${THIS_DIR}/${SCRIPT_NAME}
Expand Down
Loading