Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to read@v3 #42

Closed
wants to merge 1 commit into from

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented May 28, 2024

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Migrate read from v1 to v3. Requires a newer patch level of node so bump requirement from 14.0 to 14.17.

Just tested with unit tests.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

BREAKING: `read` requires node >=14.17
@coveralls
Copy link

Coverage Status

coverage: 81.563%. remained the same
when pulling 6aa8933 on Rotzbua:feat_migrate_read
into 16b387e on node-red:master.

@knolleary
Copy link
Member

Sorry - I overlooked this draft PR when I did a quick tidy up of this repo ahead of 4.0 - and ended up doing the same update in #44

@knolleary knolleary closed this Jun 17, 2024
@Rotzbua
Copy link
Contributor Author

Rotzbua commented Jun 17, 2024

It was still a draft because I wanted to take a second look at it. But I also overlooked it, so no problem 😉

@Rotzbua Rotzbua deleted the feat_migrate_read branch June 17, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants