Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JSON.stringify replacer argument #43

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix: JSON.stringify replacer argument #43

merged 1 commit into from
Jun 3, 2024

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented May 28, 2024

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

replacer argument can be array or function otherwise it should be e.g. null

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@Rotzbua
fix: JSON.stringify replacer argument
752b41b 
replacer argument can be array or function otherwise it should be e.g. `null`
@Rotzbua Rotzbua marked this pull request as ready for review May 28, 2024 13:01
@coveralls
Copy link

Coverage Status

coverage: 81.563%. remained the same
when pulling 752b41b on Rotzbua:fix_type_json_stringify
into 16b387e on node-red:master.

@knolleary knolleary merged commit 53f75d1 into node-red:master Jun 3, 2024
7 checks passed
@Rotzbua Rotzbua deleted the fix_type_json_stringify branch June 3, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rotzbua @coveralls @knolleary