chore(ci) test on Node.js v22 and not v16 #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengjiawen
reviewed
Jul 22, 2024
| include: # `npm test` is running Windows find-visualstudio tests on an M1 Mac!!! | ||
| - os: macos-14 | ||
| node: [18.x, 20.x, 22.x] | ||
| include: # `npm test` runs Windows find-visualstudio tests on an Intel Mac!!! |
There was a problem hiding this comment.
I think M1 Mac is more reasonable since intel not produced anymore
There was a problem hiding this comment.
Clarification: On GitHub Actions macos-latest is now macos-14 on M1 while macos-13 is legacy Intel.
Before we were mostly testing on Intel and only one test run on M1. This change reverses that. Intel is still used broadly even if it is no longer being sold.
More important is why the Node.js v22 tests are failing.
legendecas
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change