adding signal for killing zombie process

nodejs · Nov 1, 2023 · 86d977c · 86d977c
1 parent 9e09409
commit 86d977c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/test/fixtures/test-runner/timeout.js b/test/fixtures/test-runner/timeout.js
@@ -3,11 +3,14 @@ const test = require('node:test');
 const common = require('../../common');
 const fixtures = require('../../common/fixtures');
 
-test('should support timeout', async () => {
-  const stream = test.run({files: [
-    fixtures.path('test-runner', 'never_ending_sync.js'),
-    fixtures.path('test-runner', 'never_ending_async.js'),
-  ] });
+test('should support timeout', async ({ signal }) => {
+  const stream = test.run({
+    signal,
+    files: [
+      fixtures.path('test-runner', 'never_ending_sync.js'),
+      fixtures.path('test-runner', 'never_ending_async.js'),
+    ]
+  });
   stream.on('test:fail', common.mustCall(2));
   stream.on('test:pass', common.mustNotCall());
   // eslint-disable-next-line no-unused-vars

diff --git a/test/parallel/test-runner-cli.js b/test/parallel/test-runner-cli.js
@@ -116,6 +116,7 @@ const testFixtures = fixtures.path('test-runner');
 }
 
 {
+  // Test --test-timeout flag
   const args = [
     '--test',
     '--test-timeout',