build: add run order and dependancies in workflows

.github/workflows/build-tarball.yml

@@ -36,6 +36,16 @@ permissions:
 
 jobs:
   build-tarball:
+    needs:
+      - lint-addon-docs
+      - lint-cpp
+      - lint-js-and-md
+      - lint-py
+      - lint-yaml
+      - lint-sh
+      - lint-codeowners
+      - lint-pr-url
+
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:

.github/workflows/build-windows.yml

@@ -31,6 +31,16 @@ permissions:
 
 jobs:
   build-windows:
+    needs:
+      - lint-addon-docs
+      - lint-cpp
+      - lint-js-and-md
+      - lint-py
+      - lint-yaml
+      - lint-sh
+      - lint-codeowners
+      - lint-pr-url
+
     if: github.event.pull_request.draft == false
     strategy:
       matrix:

.github/workflows/coverage-linux-without-intl.yml

@@ -38,6 +38,16 @@ permissions:
 
 jobs:
   coverage-linux-without-intl:
+    needs:
+      - lint-addon-docs
+      - lint-cpp
+      - format-cpp
+      - lint-js-and-md
+      - lint-py
+      - lint-yaml
+      - lint-sh
+      - lint-codeowners
+      - lint-pr-url
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:

.github/workflows/coverage-linux.yml

@@ -38,6 +38,16 @@ permissions:
 
 jobs:
   coverage-linux:
+    needs:
+      - lint-addon-docs
+      - lint-cpp
+      - format-cpp
+      - lint-js-and-md
+      - lint-py
+      - lint-yaml
+      - lint-sh
+      - lint-codeowners
+      - lint-pr-url
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:

.github/workflows/coverage-windows.yml

@@ -38,6 +38,18 @@ permissions:
 
 jobs:
   coverage-windows:
+    needs:
+      - lint-addon-docs
+      - lint-cpp
+      - format-cpp
+      - lint-js-and-md
+      - lint-py
+      - lint-yaml
+      - lint-sh
+      - lint-codeowners
+      - lint-pr-url
+      - build-windows
+
     if: github.event.pull_request.draft == false
     runs-on: windows-2022
     steps:

.github/workflows/doc.yml

@@ -21,6 +21,9 @@ permissions:
 
 jobs:
   build-docs:
+    needs:
+      - build-tarball
+
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:

.github/workflows/linters.yml

@@ -22,6 +22,7 @@ permissions:
 
 jobs:
   lint-addon-docs:
+    needs: lint-commit-message
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -37,6 +38,7 @@ jobs:
       - name: Lint addon docs
         run: NODE=$(command -v node) make lint-addon-docs
   lint-cpp:
+    needs: lint-commit-message
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -52,6 +54,9 @@ jobs:
       - name: Lint C/C++ files
         run: make lint-cpp
   format-cpp:
+    needs:
+      - lint-commit-message
+      - lint-cpp
     if: ${{ github.event.pull_request && github.event.pull_request.draft == false && github.base_ref == github.event.repository.default_branch }}
     runs-on: ubuntu-latest
     steps:
@@ -90,6 +95,7 @@ jobs:
             exit "$EXIT_CODE"
           fi
   lint-js-and-md:
+    needs: lint-commit-message
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -115,6 +121,7 @@ jobs:
         env:
           NODE_RELEASED_VERSIONS: ${{ steps.get-released-versions.outputs.NODE_RELEASED_VERSIONS }}
   lint-py:
+    needs: lint-commit-message
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -132,6 +139,7 @@ jobs:
           make lint-py-build
           make lint-py
   lint-yaml:
+    needs: lint-commit-message
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -150,6 +158,7 @@ jobs:
           make lint-yaml
 
   lint-sh:
+    needs: lint-commit-message
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -160,6 +169,7 @@ jobs:
       - name: Lint Shell scripts
         run: tools/lint-sh.mjs .
   lint-codeowners:
+    needs: lint-commit-message
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -170,6 +180,7 @@ jobs:
         with:
           checks: files,duppatterns
   lint-pr-url:
+    needs: lint-commit-message
     if: ${{ github.event.pull_request }}
     runs-on: ubuntu-latest
     steps:

.github/workflows/test-asan.yml

@@ -38,6 +38,7 @@ permissions:
 
 jobs:
   test-asan:
+    needs: build-tarball
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-20.04
     env:

.github/workflows/test-internet.yml

@@ -37,6 +37,7 @@ permissions:
 
 jobs:
   test-internet:
+    needs: build-tarball
     if: github.repository == 'nodejs/node' || github.event_name != 'schedule'
     runs-on: ubuntu-latest
     steps:

.github/workflows/test-linux.yml

@@ -31,6 +31,7 @@ permissions:
 
 jobs:
   test-linux:
+    needs: build-tarball
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:

.github/workflows/test-macos.yml

@@ -37,6 +37,7 @@ permissions:
 
 jobs:
   test-macOS:
+    needs: build-tarball
     if: github.event.pull_request.draft == false
     runs-on: macos-latest
     steps: