build: build v8 with -fvisibility=hidden on macOS

V8 should be built with -fvisibility=hidden, otherwise the resulting binary would contain unnecessary symbols. In particular, on macOS, this leads to 5000+ weak symbols resolved at runtime, leading to a startup regression.
nodejs · Dec 16, 2024 · b8c972d · b8c972d
1 parent 938a581
commit b8c972d
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
@@ -42,6 +42,9 @@
       }
     },
   },
+  'xcode_settings': {
+    'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES',  # -fvisibility=hidden
+  },
   'targets': [
     {
       'target_name': 'v8_pch',