Skip to content

Commit

Permalink
build: fix GN build on macOS
Browse files Browse the repository at this point in the history
use_gold is not defined on macOS.

PR-URL: #56141
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
  • Loading branch information
joyeecheung authored and aduh95 committed Dec 10, 2024
1 parent cfbdff7 commit fcaa2c8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion unofficial.gni
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ template("node_gn_build") {
ldflags = [ "/OPT:NOICF" ] # link.exe, but also lld-link.exe.
} else if (is_apple && !use_lld) {
ldflags = [ "-Wl,-no_deduplicate" ] # ld64.
} else if (use_gold || use_lld) {
} else if ((!is_apple && use_gold) || use_lld) {
ldflags = [ "-Wl,--icf=none" ]
}
}
Expand Down

0 comments on commit fcaa2c8

Please sign in to comment.