Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20.7.0 proposal #49592

Merged
merged 125 commits into from
Sep 18, 2023
Merged

v20.7.0 proposal #49592

merged 125 commits into from
Sep 18, 2023

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Sep 10, 2023

2023-09-18, Version 20.7.0 (Current), @UlisesGascon

Notable Changes

  • [022f1b70c1] - src: support multiple --env-file declarations (Yagiz Nizipli) #49542
  • [4a1d1cad61] - crypto: update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
  • [a1a65f593c] - deps: upgrade npm to 10.1.0 (npm team) #49570
  • [6c2480cad9] - (SEMVER-MINOR) deps: upgrade npm to 10.0.0 (npm team) #49423
  • [bef900e56b] - doc: move and rename loaders section (Geoffrey Booth) #49261
  • [db4ce8a593] - doc: add release key for Ulises Gascon (Ulises Gascón) #49196
  • [11c85ffa98] - (SEMVER-MINOR) lib: add api to detect whether source-maps are enabled (翠 / green) #46391
  • [ec51e25ed7] - src,permission: add multiple allow-fs-* flags (Carlos Espa) #49047
  • [efdc95fbc0] - (SEMVER-MINOR) test_runner: expose location of tests (Colin Ihrig) #48975

Commits

  • [e84515594e] - benchmark: use tmpdir.resolve() (Livia Medeiros) #49137
  • [f37444e896] - bootstrap: build code cache from deserialized isolate (Joyee Cheung) #49099
  • [af6dc1754d] - bootstrap: do not generate code cache in an unfinalized isolate (Joyee Cheung) #49108
  • [cade5716df] - build: add symlink to compile_commands.json file if needed (Juan José) #49260
  • [34a2590b05] - build: expand when we run internet tests (Michael Dawson) #49218
  • [f637fd46ab] - build: fix typo libray -> library (configure.py) (michalbiesek) #49106
  • [ef3d8dd493] - crypto: remove webcrypto EdDSA key checks and properties (Filip Skokan) #49408
  • [4a1d1cad61] - crypto: update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
  • [7eb10a38ea] - crypto: remove getDefaultEncoding() (Tobias Nießen) #49170
  • [772496c030] - crypto: remove default encoding from DiffieHellman (Tobias Nießen) #49169
  • [c795083232] - crypto: remove default encoding from Hash/Hmac (Tobias Nießen) #49167
  • [08197aa010] - crypto: remove default encoding from sign/verify (Tobias Nießen) #49145
  • [a1a65f593c] - deps: upgrade npm to 10.1.0 (npm team) #49570
  • [6c2480cad9] - (SEMVER-MINOR) deps: upgrade npm to 10.0.0 (npm team) #49423
  • [84195d9584] - deps: add missing thread-common.c in uv.gyp (Santiago Gimeno) #49410
  • [5b70b68b3d] - deps: V8: cherry-pick eadaef581c29 (Adam Majer) #49401
  • [fe34d632e8] - deps: update zlib to 1.2.13.1-motley-f5fd0ad (Node.js GitHub Bot) #49252
  • [db4ce8a593] - doc: add release key for Ulises Gascon (Ulises Gascón) #49196
  • [e5f3a694cf] - doc: fix node-api call example (Chengzhong Wu) #49395
  • [021345a724] - doc: add news issue for Diagnostics WG (Michael Dawson) #49306
  • [f82347266b] - doc: clarify policy expectations (Rafael Gonzaga) #48947
  • [73cfd9c895] - doc: add print results for examples in StringDecoder (Jungku Lee) #49326
  • [63ab591416] - doc: update outdated reference to NIST SP 800-131A (Tobias Nießen) #49316
  • [935dfe2afd] - doc: use cjs as block code's type in MockTimers (Deokjin Kim) #49309
  • [7c0cd2fb87] - doc: update options.filter description for fs.cp (Shubham Pandey) #49289
  • [f72e79ea67] - doc: add riscv64 to list of architectures (Stewart X Addison) #49284
  • [d19c710064] - doc: avoid "not currently recommended" (Tobias Nießen) #49300
  • [ae656101c0] - doc: update module hooks docs (Geoffrey Booth) #49265
  • [fefbdb92f2] - doc: modify param description for end(),write() in StringDecoder (Jungku Lee) #49285
  • [59e66a1ebe] - doc: use NODE_API_SUPPORTED_VERSION_MAX in release doc (Cheng Zhao) #49268
  • [ac3b88449b] - doc: fix typo in stream.finished documentation (Antoine du Hamel) #49271
  • [7428ebf6c3] - doc: update description for percent_encode sets in WHATWG API (Jungku Lee) #49258
  • [bef900e56b] - doc: move and rename loaders section (Geoffrey Booth) #49261
  • [a22e0d9696] - doc: clarify use of Uint8Array for n-api (Fedor Indutny) #48742
  • [1704f24cb9] - doc: add signature for module.register (Geoffrey Booth) #49251
  • [5a363bb01b] - doc: caveat unavailability of import.meta.resolve in custom loaders (Jacob Smith) #49242
  • [8101f2b259] - doc: use same name in the doc as in the code (Hyunjin Kim) #49216
  • [edf278d60d] - doc: add notable-change label mention to PR template (Rafael Gonzaga) #49188
  • [3df2251a6a] - doc: add h1 summary to security release process (Rafael Gonzaga) #49112
  • [9fcd99a744] - doc: update to semver-minor releases by default (Rafael Gonzaga) #49175
  • [777931f499] - doc: fix wording in napi_async_init (Tobias Nießen) #49180
  • [f45c8e10c0] - doc,test: add known path resolution issue in permission model (Tobias Nießen) #49155
  • [a6cfea3f74] - esm: align sync and async load implementations (Antoine du Hamel) #49152
  • [9fac310b33] - fs: add the options param description in openAsBlob() (Yeseul Lee) #49308
  • [92772a8175] - fs: remove redundant code in readableWebStream() (Deokjin Kim) #49298
  • [88ba79b083] - fs: make sure to write entire buffer (Robert Nagy) #49211
  • [11c85ffa98] - (SEMVER-MINOR) lib: add api to detect whether source-maps are enabled (翠 / green) #46391
  • [c12711ebfe] - lib: implement WeakReference on top of JS WeakRef (Joyee Cheung) #49053
  • [9a0891f88d] - meta: bump step-security/harden-runner from 2.5.0 to 2.5.1 (dependabot[bot]) #49435
  • [ae67f41ef1] - meta: bump actions/checkout from 3.5.3 to 3.6.0 (dependabot[bot]) #49436
  • [71b4411fb2] - meta: bump actions/setup-node from 3.7.0 to 3.8.1 (dependabot[bot]) #49434
  • [83b7d3a395] - meta: remove modules team from CODEOWNERS (Benjamin Gruenbaum) #49412
  • [81ff68c45c] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #49264
  • [ab975233cc] - meta: mention nodejs/tsc when changing GH templates (Rafael Gonzaga) #49189
  • [ceaa5494de] - meta: add test/reporters to codeowners (Chemi Atlow) #49186
  • [de0a51b7cf] - net: improve performance of isIPv4 and isIPv6 (Uzlopak) #49568
  • [8d0913bf95] - net: use asserts in JS Socket Stream to catch races in future (Tim Perry) #49400
  • [2486836a7d] - net: fix crash due to simultaneous close/shutdown on JS Stream Sockets (Tim Perry) #49400
  • [7a808340cd] - node-api: fix compiler warning in node_api.h (Michael Graeb) #49103
  • [30f26a99f4] - permission: ensure to resolve path when calling mkdtemp (RafaelGSS) nodejs-private/node-private#440
  • [5051c75a5b] - policy: fix path to URL conversion (Antoine du Hamel) #49133
  • [173aed4757] - report: fix recent coverity warning (Michael Dawson) #48954
  • [d7ff78b442] - sea: generate code cache with deserialized isolate (Joyee Cheung) #49226
  • [022f1b70c1] - src: support multiple --env-file declarations (Yagiz Nizipli) #49542
  • [154b1c2115] - src: don't overwrite environment from .env file (Phil Nash) #49424
  • [dc4de1c69b] - src: modify code for empty string (pluris) #49336
  • [701c46f967] - src: remove unused PromiseWrap-related code (Joyee Cheung) #49335
  • [4a094dc7af] - src: rename IsAnyByteSource to IsAnyBufferSource (Tobias Nießen) #49346
  • [55d6649175] - src: support snapshot deserialization in RAIIIsolate (Joyee Cheung) #49226
  • [dc092864ef] - src: remove unused function GetName() in node_perf (Jungku Lee) #49244
  • [f2552a410e] - src: use ARES_SUCCESS instead of 0 (Jungku Lee) #49048
  • [4a9ae31519] - src: add a condition if the argument of DomainToUnicode is empty (Jungku Lee) #49097
  • [f460362cdf] - src: remove C++ WeakReference implementation (Joyee Cheung) #49053
  • [2a35383b3e] - src: use per-realm GetBindingData() wherever applicable (Joyee Cheung) #49007
  • [184bbddcf5] - src: add per-realm GetBindingData() method (Joyee Cheung) #49007
  • [e9946885f9] - src: serialize both BaseObject slots (Joyee Cheung) #48996
  • [ec51e25ed7] - src,permission: add multiple allow-fs-* flags (Carlos Espa) #49047
  • [8aac95de4b] - stream: improve tee perf by reduce ReflectConstruct usages (Raz Luvaton) #49546
  • [0eea7fd8fb] - stream: use Buffer.from when constructor is a Buffer (Matthew Aitken) #49250
  • [b961d9bd52] - stream: add highWaterMark for the map operator (Raz Luvaton) #49249
  • [ca1384166d] - test: fix warning for comment in embedtest (Jungku Lee) #49416
  • [2a35782809] - test: simplify test-crypto-dh-group-setters (Tobias Nießen) #49404
  • [6740f3c209] - test: verify dynamic import call with absolute path strings (Chengzhong Wu) #49275
  • [6ed47bd8fb] - test: reduce length in crypto keygen tests (Joyee Cheung) #49221
  • [4faa30c553] - test: split JWK async elliptic curve keygen tests (Joyee Cheung) #49221
  • [e04a2603d8] - test: split test-crypto-keygen.js (Joyee Cheung) #49221
  • [0d23c1d4ce] - test: rename test-crypto-modp1-error (Tobias Nießen) #49348
  • [48e41569e2] - test: migrate message source map tests from Python to JS (Yiyun Lei) #49238
  • [a11e64e09c] - test: fix compiler warning in NodeCryptoEnv (Tobias Nießen) #49206
  • [345543938f] - test: handle EUNATCH (Abdirahim Musse) #48050
  • [e391f4b197] - test: use tmpdir.resolve() (Livia Medeiros) #49136
  • [910378f93f] - test: reduce flakiness of test-esm-loader-hooks (Antoine du Hamel) #49248
  • [4a85f70462] - test: add spawnSyncAndExit() and spawnSyncAndExitWithoutError() (Joyee Cheung) #49200
  • [9610008b79] - test: make test-perf-hooks more robust and work with workers (Joyee Cheung) #49197
  • [dc8fff9a75] - test: use gcUntil() in test-v8-serialize-leak (Joyee Cheung) #49168
  • [ca9f801332] - test: make WeakReference tests robust (Joyee Cheung) #49053
  • [de103a4686] - test: add test for effect of UV_THREADPOOL_SIZE (Tobias Nießen) #49165
  • [47d24f144b] - test: use expectSyncExit{WithErrors} in snapshot tests (Joyee Cheung) #49020
  • [c441f5a097] - test: add expectSyncExitWithoutError() and expectSyncExit() utils (Joyee Cheung) #49020
  • [4d184b5251] - test: remove --no-warnings flag in test_runner fixtures (Raz Luvaton) #48989
  • [25e967a90b] - test: reorder test files fixtures for better understanding (Raz Luvaton) #48787
  • [fac56dbcc0] - test,benchmark: use tmpdir.fileURL() (Livia Medeiros) #49138
  • [36763fa532] - test_runner: preserve original property descriptor (Erick Wendel) #49433
  • [40e9fcdbea] - test_runner: add support for setImmediate (Erick Wendel) #49397
  • [23216f1935] - test_runner: report covered lines, functions and branches to reporters (Phil Nash) #49320
  • [283f2806b1] - test_runner: expose spec reporter as newable function (Chemi Atlow) #49184
  • [546ad5f770] - test_runner: reland run global after() hook earlier (Colin Ihrig) #49116
  • [efdc95fbc0] - (SEMVER-MINOR) test_runner: expose location of tests (Colin Ihrig) #48975
  • [4bc0a8fe99] - test_runner: fix global after not failing the tests (Raz Luvaton) #48913
  • [08738b2664] - test_runner: fix timeout in *Each hook failing further tests (Raz Luvaton) #48925
  • [c2f1830f66] - test_runner: cleanup test timeout abort listener (Raz Luvaton) #48915
  • [75333f38b2] - test_runner: fix global before not called when no global test exists (Raz Luvaton) #48877
  • [b28b85adf8] - tls: remove redundant code in onConnectSecure() (Deokjin Kim) #49457
  • [83fc4dccbc] - tls: refactor to use validateFunction (Deokjin Kim) #49422
  • [8949cc79dd] - tls: ensure TLS Sockets are closed if the underlying wrap closes (Tim Perry) #49327
  • [1df56e6f01] - tools: update eslint to 8.48.0 (Node.js GitHub Bot) #49343
  • [ef50ec5b57] - tools: update lint-md-dependencies (Node.js GitHub Bot) #49342
  • [9a8fb4fc34] - tools: remove v8_dump_build_config action (Cheng Zhao) #49301
  • [91b2d4314b] - tools: update lint-md-dependencies (Node.js GitHub Bot) #49253
  • [b51946ebdd] - tools: fix github reporter appended multiple times (Moshe Atlow) #49199
  • [ae40cb1612] - url: validate pathToFileURL(path) argument as string (LiviaMedeiros) #49161
  • [e787673dcf] - url: handle unicode hostname if empty (Yagiz Nizipli) #49396
  • [6ee74be87f] - vm: store MicrotaskQueue in ContextifyContext directly (Joyee Cheung) #48982
  • [0179c6dc8f] - worker: protect against user mutating well-known prototypes (Antoine du Hamel) #49270

rluvaton and others added 30 commits September 10, 2023 18:03
PR-URL: #48787
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #48877
Backport-PR-URL: #49225
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
fix #48475

PR-URL: #48915
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #48925
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #48913
Backport-PR-URL: #49225
Fixes: #48867
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
no longer needed after #48915 fix

PR-URL: #48989
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
This commit adds each test's line and column number to the reporter
output. This will aid in debugging test suite failures when error
stacks are not helpful, test suites are large, or tests have the
same name. This data is also exposed on the spec reporter.

This commit also replaces the filename that was previously being
reported, with the filename where the test actually exists. These
are normally correct, but could be wrong if tests were run from
a file other than the user's entrypoint.

PR-URL: #48975
Backport-PR-URL: #49225
Fixes: #48457
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Backport-PR-URL: #49225
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
We previously only return startup data for the first slot for
BaseObjects because we can already serialize all the necessary
information in one go, but slots that do not get special startup
data would be serialized verbatim which means that the pointer
addresses are going to be part of the snapshot blob, resulting
in indeterminism.

This patch updates the serialization routines and capture information
for both of the two slots - the first slot with type information
and memory management type (which we can use in the future for
cppgc-managed objects) and the second slot with data about the
object itself. This way the embeedder slots can be serialized
in a reproducible manner in the snapshot.

PR-URL: #48996
Refs: nodejs/build#3043
Reviewed-By: Rafael Gonzaga <[email protected]>
Signed-off-by: Michal Biesek <[email protected]>
PR-URL: #49106
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Fix warning about dereferencing null env

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #48954
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
getDefaultEncoding() always returns 'buffer' in Node.js 20. It requires
some careful justification but the default encoding can be eliminated
from sig.js entirely.

In Sign.prototype.update, we can safely remove the conditional
assignment of getDefaultEncoding() to encoding. This is because
SignUpdate() in crypto_sig.cc internally calls node::crypto::Decode,
which returns UTF8 for falsy encoding values. In other words, with the
conditional assignment, StringBytes::Write() ultimately receives the
encoding BUFFER, and without the conditional assignment, it receives the
encoding UTF8. However, StringBytes::Write() treats both encodings
identically, so there is no need to deviate from the internal default
encoding UTF8.

In Sign.prototype.sign, we can also safely remove the conditional
assignment of getDefaultEncoding() to encoding. Whether encoding is
falsy or 'buffer' makes no difference.

In Verify.prototype.verify, we can also safely remove the conditional
assignment of getDefaultEncoding() to sigEncoding. This is because the
function passes the sigEncoding to getArrayBufferOrView(), which passes
it to Buffer.from(). If sigEncoding is 'buffer', getArrayBufferOrView()
instead passes 'utf8' to Buffer.from(). Because the default encoding of
Buffer.from() is 'utf8', passing a falsy encoding to
getArrayBufferOrView() instead of 'buffer' results in the same behavior.

Refs: #47182
PR-URL: #49145
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This version avoids the additional access to the embedder slot
when we already have a reference to the realm.

PR-URL: #49007
Refs: #48836
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
This reduce the number of embedder slot accesses and also removes
the assumption in a few binding methods that the current realm is
the principal realm of the current environment (which is not true
for shadow realms).

PR-URL: #49007
Refs: #48836
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
These can be used to check the state and the output of a child
process launched with `spawnSync()`. They log additional information
about the child process when the check fails to facilitate debugging
test failures.

PR-URL: #49020
Reviewed-By: Luigi Pinca <[email protected]>
..and replace the similar code added for logging.

PR-URL: #49020
Reviewed-By: Luigi Pinca <[email protected]>
This (not particularly elegant) native addon tests the effect of
UV_THREADPOOL_SIZE on node-api. The test fails if Node.js allows more
than UV_THREADPOOL_SIZE async tasks to run concurrently, or if it limits
the number of concurrent async tasks to anything less than
UV_THREADPOOL_SIZE.

PR-URL: #49165
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
getDefaultEncoding() always returns 'buffer' in Node.js 20. It requires
some careful justification but the default encoding can be eliminated
from hash.js entirely. The reasoning is almost identical with that in
#49145 so I won't repeat it here.

Refs: #47182
PR-URL: #49167
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
getDefaultEncoding() always returns 'buffer' in Node.js 20.

In diffiehellman.js, this value is always used as input to either
toBuf(), encode(), or getArrayBufferOrView(). All of these functions
treat any falsy encoding just like 'buffer', so we can safely remove the
calls to getDefaultEncoding().

Refs: #47182
PR-URL: #49169
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Previously we assume that the objects are GC'ed after one
global.gc() returns, which is not necessarily always the case. Use
gcUntil() to run GC multiple times if they are not GC'ed in the
first time around.

PR-URL: #49053
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
The C++ implementation can now be done entirely in JS using WeakRef.
Re-implement it in JS instead to simplify the code.

PR-URL: #49053
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #49053
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #49199
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Previously the ContextifyContext holds a MicrotaskQueueWrap which in
turns holds a MicrotaskQueue in a shared pointer. The indirection is
actually unnecessary, we can directly hold the MicrotaskQueue via
a unique pointer in ContextifyContext, the lifetime would still
remain the same but the graph would be simpler, and this removes
the additional JS -> C++ to create the wrapper object.

PR-URL: #48982
Reviewed-By: Stephen Belanger <[email protected]>
Add `process.sourceMapsEnabled` to detect
whether source-maps are enabled.

Fixes: #46304
PR-URL: #46391
Reviewed-By: Chemi Atlow <[email protected]>
V8 now no longer supports serializing code cache in an isolate
with unfinalized read-only space. So guard the code cache regeneration
with the `is_building_snapshot()` flag. When the isolate is created
for snapshot generation, the code cache is going to be serialized
separately anyway, so there is no need to do it in the builtin loader.

PR-URL: #49108
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Fixes: #48112
Ref: #48208
PR-URL: #49184
Refs: #48208
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: #49186
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Support for a single comma separates list for allow-fs-* flags is
removed. Instead now multiple flags can be passed to allow multiple
paths.

Fixes: nodejs/security-wg#1039
PR-URL: #49047
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
UlisesGascon added a commit that referenced this pull request Sep 16, 2023
Notable changes:

crypto:
  * update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
doc:
  * move and rename loaders section (Geoffrey Booth) #49261
  * add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
  * support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
  * add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
  * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975

PR-URL: #49592
@UlisesGascon
Copy link
Member Author

UlisesGascon commented Sep 16, 2023

@UlisesGascon I think you need a new run of CITGM for v20.x and v20.7.0-proposal branch. 81 failures is A LOT.

Yes, I agree. I created a new run (https://ci.nodejs.org/job/citgm-smoker/3246/) and I will run an additional one without macos based on nodejs/citgm#971. That way it will be easier to compare and validate the release (I hope)

@UlisesGascon
Copy link
Member Author

@UlisesGascon I think with the all clear from @mcollina and no other concerns/objections in this issue as well as no objections in nodejs/Release#884 to it going into 20.x at this point** the consensus is that you should pull npm@10. in.

** at least grudgingly as the discussion makes it clear we'd prefer npm releases tied more closely to the Node.js release cycle versus trying to squeeze it in just before a release goes LTS.

Thanks a lot! I added npm@10 👍

@UlisesGascon UlisesGascon added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2023
@nodejs-github-bot
Copy link
Collaborator

@UlisesGascon
Copy link
Member Author

UlisesGascon commented Sep 16, 2023

CI Details

CITGM Details

--------------------------------------------------------------------------------
[1/1] Running CITGM: 3250
--------------------------------------------------------------------------------
✔  Summary data downloaded
✔  Results data downloaded
✔  Summary data downloaded
✔  Results data downloaded
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/citgm-smoker/3250/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/v20.x
Commit     [3dbc61c85f44] Working on: v20.6.2
Date       2023-09-08 11:38:44 -0400
Author     Ruy Adorno <[email protected]>
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/citgm-smoker/3246/
Source     https://github.com/nodejs/node/pull/49592/
Commit     [3557c436181c] 2023-09-18, Version 20.7.0 (Current)
Date       2023-09-16 11:02:46 +0000
Author     Ulises Gascón <[email protected]>
----------------------------------- Results ------------------------------------



FAILURE: 20 failures in 3246 not present in 3250


┌────────────────────────┬───────────────────────┬───────────────────────┬──────────────────────┬───────────────────────┬─────────────────────────┬──────────────┬───────────────────────────┐
│        (index)         │           0           │           1           │          2           │           3           │            4            │      5       │             6             │
├────────────────────────┼───────────────────────┼───────────────────────┼──────────────────────┼───────────────────────┼─────────────────────────┼──────────────┼───────────────────────────┤
│       win-vs2019       │    'async-v3.2.4'     │  'commander-v11.0.0'  │ 'browserify-v17.0.0' │   'fastify-v4.23.2'   │ 'torrent-stream-v1.2.1' │ 'ws-v8.14.1' │ 'yeoman-generator-v5.9.0' │
│     ubuntu1804-64      │    'async-v3.2.4'     │ 'tough-cookie-v4.1.3' │                      │                       │                         │              │                           │
│      debian10-x64      │    'bcrypt-v5.1.1'    │     'pump-v3.0.0'     │                      │                       │                         │              │                           │
│      aix72-ppc64       │ 'tough-cookie-v4.1.3' │                       │                      │                       │                         │              │                           │
│ fedora-last-latest-x64 │                       │                       │                      │                       │                         │              │                           │
│       rhel8-x64        │                       │                       │                      │                       │                         │              │                           │
│        osx1015         │ 'underscore-v1.13.6'  │                       │                      │                       │                         │              │                           │
│      rhel8-s390x       │                       │                       │                      │                       │                         │              │                           │
│     rhel8-ppc64le      │    'async-v3.2.4'     │    'bcrypt-v5.1.1'    │    'nan-v2.18.0'     │ 'multer-v1.4.5-lts.1' │    'undici-v5.24.0'     │              │                           │
│   fedora-latest-x64    │    'bcrypt-v5.1.1'    │    'rewire-v7.0.0'    │                      │                       │                         │              │                           │
└────────────────────────┴───────────────────────┴───────────────────────┴──────────────────────┴───────────────────────┴─────────────────────────┴──────────────┴───────────────────────────┘

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

UlisesGascon added a commit that referenced this pull request Sep 18, 2023
Notable changes:

crypto:
  * update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
deps:
  * upgrade npm to 10.0.0 (npm team) #49423
  * upgrade npm to 10.1.0 (npm team) #49570
doc:
  * move and rename loaders section (Geoffrey Booth) #49261
  * add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
  * support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
  * add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
  * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975

PR-URL: #49592
Notable changes:

crypto:
  * update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
deps:
  * upgrade npm to 10.1.0 (npm team) #49570
  * upgrade npm to 10.0.0 (npm team) #49423
doc:
  * move and rename loaders section (Geoffrey Booth) #49261
  * add release key for Ulises Gascon (Ulises Gascón) #49196
lib:
  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391
src:
  * support multiple `--env-file` declarations (Yagiz Nizipli) #49542
src,permission:
  * add multiple allow-fs-* flags (Carlos Espa) #49047
test_runner:
  * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975

PR-URL: #49592
@UlisesGascon UlisesGascon merged commit a71037e into v20.x Sep 18, 2023
21 checks passed
@UlisesGascon UlisesGascon deleted the v20.7.0-proposal branch September 18, 2023 17:03
UlisesGascon added a commit that referenced this pull request Sep 18, 2023
UlisesGascon added a commit to UlisesGascon/node that referenced this pull request Sep 18, 2023
Notable changes:

crypto:
  * update root certificates to NSS 3.93 (Node.js GitHub Bot) nodejs#49341
deps:
  * upgrade npm to 10.1.0 (npm team) nodejs#49570
  * upgrade npm to 10.0.0 (npm team) nodejs#49423
doc:
  * move and rename loaders section (Geoffrey Booth) nodejs#49261
  * add release key for Ulises Gascon (Ulises Gascón) nodejs#49196
lib:
  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) nodejs#46391
src:
  * support multiple `--env-file` declarations (Yagiz Nizipli) nodejs#49542
src,permission:
  * add multiple allow-fs-* flags (Carlos Espa) nodejs#49047
test_runner:
  * (SEMVER-MINOR) expose location of tests (Colin Ihrig) nodejs#48975

PR-URL: nodejs#49592
UlisesGascon added a commit to UlisesGascon/nodejs.org that referenced this pull request Sep 18, 2023
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Sep 18, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Notable changes:

crypto:
  * update root certificates to NSS 3.93 (Node.js GitHub Bot) nodejs#49341
deps:
  * upgrade npm to 10.1.0 (npm team) nodejs#49570
  * upgrade npm to 10.0.0 (npm team) nodejs#49423
doc:
  * move and rename loaders section (Geoffrey Booth) nodejs#49261
  * add release key for Ulises Gascon (Ulises Gascón) nodejs#49196
lib:
  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) nodejs#46391
src:
  * support multiple `--env-file` declarations (Yagiz Nizipli) nodejs#49542
src,permission:
  * add multiple allow-fs-* flags (Carlos Espa) nodejs#49047
test_runner:
  * (SEMVER-MINOR) expose location of tests (Colin Ihrig) nodejs#48975

PR-URL: nodejs#49592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.