Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing for instead of foreach GHC23 #49796

Closed
wants to merge 2 commits into from
Closed

Conversation

Hannahjef
Copy link

Yes

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 22, 2023
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 22, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 2, 2023

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 11, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49796
✔  Done loading data for nodejs/node/pull/49796
----------------------------------- PR info ------------------------------------
Title      Replacing for instead of foreach GHC23 (#49796)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Hannahjef:main -> nodejs:main
Labels     test, code-and-learn, needs-ci
Commits    2
 - Replacing for instead of foreach GHC23
 - Update test/parallel/test-tls-ecdh-multiple.js
Committers 2
 - Hannahjef <[email protected]>
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49796
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49796
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 22 Sep 2023 22:59:43 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49796#pullrequestreview-1709626731
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/49796#pullrequestreview-1726082969
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-11-02T07:56:32Z: https://ci.nodejs.org/job/node-test-pull-request/55413/
- Querying data for job/node-test-pull-request/55413/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6835327454

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you follow our commit guidelines?

@avivkeller
Copy link
Member

Hi! It's been a few months since changes were requested on this PR. @Hannahjef, if you'd still like to pursue this, please make the requested changes, or a team member can open a new-PR with the requested changes.

Thank you!

@RafaelGSS RafaelGSS closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants