-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esm: backport dirname and filename to v20 #50502
Conversation
This adds `import.meta.dirname` and `import.meta.filename` to the v20 release line.
Review requested:
|
<!-- YAML | ||
added: REPLACEME | ||
--> | ||
|
||
> Stability: 1.2 - Release candidate | ||
|
||
* {string} The directory name of the current module. This is the same as the | ||
[`path.dirname()`][] of the [`import.meta.filename`][]. | ||
|
||
> **Caveat**: only present on `file:` modules. | ||
|
||
### `import.meta.filename` | ||
|
||
<!-- YAML | ||
added: REPLACEME | ||
--> | ||
|
||
> Stability: 1.2 - Release candidate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear if I should be changing these YAML blocks, and what I should be altering them to if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsumners as I understand, the REPLACEME
is placeholder for a version that should be a release version, like this:
<!-- YAML
added: 1.2.0
-->
Hence, this readme file should be updated on each release with the accorded version.
I appreciate the initiative, but there are two things to consider for LTS release lines:
|
@jsumners The release team generally takes care of backports, usually without a specific PR for each one unless a commit doesn’t land cleanly (without conflicts). If that happens they’ll leave a comment on the original PR requesting a backport PR. |
Co-authored-by: Alex Strizhak <[email protected]>
To be clear: we should see the feature flow back to v20 and v18 without any further intervention from myself or another interested party? |
@jsumners Yes, semver-minor changes are generally backported automatically to existing release lines. However, because Node.js 18 has reached its maintenance phase, only critical bug fixes and security updates are backported automatically, but "new features may be added at the discretion of the LTS team." |
I was about to open another issue regarding backporting
@tniessen @jsumners Does this mean they will not be backported to Node 18/19? |
🤷♂️ what you see in this thread is all the information I have. My original intention was to get it ported all the way back to 18. But I'm not willing to put in the effort any longer. At this point, it would probably take the remaining lifetime of 18 to get it there (review the original PR). |
@danielbayley Node.js 18 is about half a year away from end-of-life status, and all users should be migrating to Node.js 20 or ideally to Node.js 22. Unless you can convince someone from the LTS team that this is super crucial for the last few months of Node.js 18's lifetime, this will not be backported. Node.js 19 reached end-of-life status a while ago and should not be used at all. The same will be true for Node.js 18 in a few months. |
This adds
import.meta.dirname
andimport.meta.filename
to the v20 release line. It is a backport of #48740.