Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: cherry-pick 13192d6e10fa #50552

Merged
merged 1 commit into from
Nov 6, 2023
Merged

deps: V8: cherry-pick 13192d6e10fa #50552

merged 1 commit into from
Nov 6, 2023

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented Nov 4, 2023

This PR fixes compilation errors on riscv64.

See compilation errors in this build log: https://paste.rs/h6xxt

Needs to be backported to v21.x-staging.

Original commit message:

[riscv][tagged-ptr] Convert more Objects to Tagged<>

Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80

Bug: v8:12710

Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
Reviewed-by: Ji Qiu <[email protected]>
Commit-Queue: Ji Qiu <[email protected]>
Auto-Submit: Yahan Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#89780}

Refs: v8/v8@13192d6

@kxxt
deps: V8: cherry-pick 13192d6e10fa
d5b70d2 
Original commit message:

    [riscv][tagged-ptr] Convert more Objects to Tagged<>

    Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80

    Bug: v8:12710

    Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Ji Qiu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89780}

Refs: v8/v8@13192d6
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Nov 4, 2023
@kxxt kxxt mentioned this pull request Nov 4, 2023
Closed
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55443/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5646/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5646/

@targos targos added the riscv64 Issues and PRs related to the riscv64 architecture. label Nov 4, 2023
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5646/

@github-actions github-actions bot mentioned this pull request Nov 5, 2023
Open
13 tasks
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Nov 5, 2023
@kxxt
upgpatch: nodejs 21.1.0-1
b3350bd 
- Fix v8 compilation errors, upstreamed to nodejs: nodejs/node#50552
- Remove the `-fno-strict-aliasing` flag addition. The relevant error no
  longer occurs. Actually, we never do this to nodejs-lts-hydrogen after
  nodejs 18 is packaged as nodejs-lts-hydrogen.
@kxxt kxxt mentioned this pull request Nov 5, 2023
Merged
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Nov 5, 2023
@kxxt @felixonmars
upgpatch: nodejs 21.1.0-1
a3664bc 
- Fix v8 compilation errors, upstreamed to nodejs: nodejs/node#50552
- Remove the `-fno-strict-aliasing` flag addition. The relevant error no
  longer occurs. Actually, we never do this to nodejs-lts-hydrogen after
  nodejs 18 is packaged as nodejs-lts-hydrogen.
@github-actions github-actions bot mentioned this pull request Nov 6, 2023
Open
15 tasks
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 6, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55457/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2023
@nodejs-github-bot nodejs-github-bot merged commit 2238532 into nodejs:main Nov 6, 2023
39 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2238532

This was referenced Nov 7, 2023
Open
Open
@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Open
20 tasks
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
@kxxt @anonrig
deps: V8: cherry-pick 13192d6e10fa
35caf44 
Original commit message:

    [riscv][tagged-ptr] Convert more Objects to Tagged<>

    Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80

    Bug: v8:12710

    Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Ji Qiu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89780}

Refs: v8/v8@13192d6
PR-URL: nodejs#50552
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 10, 2023
Open
18 tasks
@targos targos mentioned this pull request Nov 10, 2023
Closed
@luyahan luyahan mentioned this pull request Nov 10, 2023
Closed
targos pushed a commit that referenced this pull request Nov 11, 2023
@kxxt @targos
deps: V8: cherry-pick 13192d6e10fa
c5c2a31 
Original commit message:

    [riscv][tagged-ptr] Convert more Objects to Tagged<>

    Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80

    Bug: v8:12710

    Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Ji Qiu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89780}

Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@kxxt @targos
deps: V8: cherry-pick 13192d6e10fa
78b3432 
Original commit message:

    [riscv][tagged-ptr] Convert more Objects to Tagged<>

    Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80

    Bug: v8:12710

    Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Ji Qiu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89780}

Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@kxxt @UlisesGascon
deps: V8: cherry-pick 13192d6e10fa
52bb65c 
Original commit message:

    [riscv][tagged-ptr] Convert more Objects to Tagged<>

    Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80

    Bug: v8:12710

    Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Ji Qiu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89780}

Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@kxxt @UlisesGascon
deps: V8: cherry-pick 13192d6e10fa
83f1294 
Original commit message:

    [riscv][tagged-ptr] Convert more Objects to Tagged<>

    Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80

    Bug: v8:12710

    Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Ji Qiu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89780}

Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@kxxt @UlisesGascon
deps: V8: cherry-pick 13192d6e10fa
d9fa44c 
Original commit message:

    [riscv][tagged-ptr] Convert more Objects to Tagged<>

    Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80

    Bug: v8:12710

    Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Ji Qiu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89780}

Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@kxxt @UlisesGascon
deps: V8: cherry-pick 13192d6e10fa
1910b6b 
Original commit message:

    [riscv][tagged-ptr] Convert more Objects to Tagged<>

    Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80

    Bug: v8:12710

    Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Ji Qiu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89780}

Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Jan 9, 2024
@kxxt @UlisesGascon
deps: V8: cherry-pick 13192d6e10fa
bc2ebb9 
Original commit message:

    [riscv][tagged-ptr] Convert more Objects to Tagged<>

    Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80

    Bug: v8:12710

    Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Ji Qiu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89780}

Refs: v8/v8@13192d6
PR-URL: #50552
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Jan 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadree25 debadree25 debadree25 approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. riscv64 Issues and PRs related to the riscv64 architecture. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kxxt @nodejs-github-bot @targos @gengjiawen @richardlau @debadree25