-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: increase iteration counts for 4 cases #50869
Conversation
Can you please update the first commit message to something like: Septa2112@a13bb22 Maybe Also, how are you generating this |
please update the first commit message to something like: Septa2112@a13bb22
I wrote a script to compare the before and after score. As the perf_hooks testing methods are only a few, so I will not split the commit. I have updated the commit msg. Could you please go ahead to approve it? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
Commit Queue failed- Loading data for nodejs/node/pull/50869 ✔ Done loading data for nodejs/node/pull/50869 ----------------------------------- PR info ------------------------------------ Title benchmark: increase iteration counts for 4 cases (#50869) Author Lei Shi (@lucshi) Branch lucshi:my-branch-5 -> nodejs:main Labels benchmark, author ready, perf_hooks Commits 1 - benchmark: update iterations in benchmark/perf_hooks Committers 1 - Lei Shi PR-URL: https://github.com/nodejs/node/pull/50869 Refs: https://github.com/nodejs/node/issues/50571 Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50869 Refs: https://github.com/nodejs/node/issues/50571 Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 23 Nov 2023 07:06:59 GMT ✔ Approvals: 1 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50869#pullrequestreview-1750127621 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50869 From https://github.com/nodejs/node * branch refs/pull/50869/merge -> FETCH_HEAD ✔ Fetched commits as 27b2ce5ba633..3c6f29b785d1 -------------------------------------------------------------------------------- error: cherry-pick is already in progress hint: try "git cherry-pick (--continue | --abort | --quit)" fatal: cherry-pick failed ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/7105099049 |
Landed in 3b758b3 |
Fixes: #50571 PR-URL: #50869 Refs: #50571 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #50571 PR-URL: #50869 Refs: #50571 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Increase the iteration counts to 10X to reflect real performance of perf hooks timing.
Refs: #50571
Belowing are the improved ratio with 10X iteration:
performance-observer.js
./node/benchmark//perf_hooks/performance-observer.js n=1000000
perf_hooks/performance-observer.js pending=1 n=1000000 percent=111.33%
perf_hooks/performance-observer.js pending=10 n=1000000 percent=127.58%
resourcetiming.js
./node/benchmark//perf_hooks/resourcetiming.js n=1000000
perf_hooks/resourcetiming.js observe="resource" n=1000000 percent=135.24%
timerfied.js
./node/benchmark//perf_hooks/timerfied.js n=1000000
perf_hooks/timerfied.js observe="function" n=1000000 percent=116.11%
usertiming.js
./node/benchmark//perf_hooks/usertiming.js n=1000000
perf_hooks/usertiming.js observe="all" n=1000000 percent=823.76%
perf_hooks/usertiming.js observe="measure" n=1000000 percent=1039.62%