[v20.x backport] streams: fixes for webstreams #52773
Conversation
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MattiasBuelens
force-pushed
the
backport-51168-to-v20.x
branch
2 times, most recently
from
43c8f92
to
a7758ee
Compare
|
can you fix the conflicts? I'll try to backport it in the next v20 release |
MattiasBuelens
force-pushed
the
backport-51168-to-v20.x
branch
from
a7758ee
to
c6f0199
Compare
|
@marco-ippolito Updated and ready for review. 😉 |
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
|
Hi @MattiasBuelens I was backporting your commits, I encountered some issue, can you please cherry-pick the landed commits from the original PR (example #51168 (comment)), instead of the commits from your fork, so that they contain metadata like PR-URL and reviewers, and please squash the fixup commits |
marco-ippolito
force-pushed
the
v20.x-staging
branch
3 times, most recently
from
a924e20
to
473fa73
Compare
MattiasBuelens
force-pushed
the
backport-51168-to-v20.x
branch
from
c6f0199
to
773f990
Compare
PR-URL: nodejs#51168 Backport-PR-URL: nodejs#52773 Reviewed-By: Matteo Collina <[email protected]>
MattiasBuelens
force-pushed
the
backport-51168-to-v20.x
branch
from
773f990
to
573f5df
Compare
|
@marco-ippolito I've squashed the commits on this PR and rebased them onto The original PR didn't have the most prominent change in the first commit, so we landed it in 20c6313 with the unimaginative title "stream: fix code style". 😅 I changed it to "stream: fixes for webstreams" for this PR, if that's okay. |
You can just cherry-pick the landed commits from the original PR (at the end of the pr in the comment from the bot landed in ...) and squash only the fixup commits |
PR-URL: #51168 Backport-PR-URL: #52773 Reviewed-By: Matteo Collina <[email protected]>
|
Landed in 48138af |
Manual backport of #51168 to v20.x.
Depends on #52772, so keeping this in draft until that one lands.
This one was a bit tricky, since there are changes to transferables on v22.x that are not on v20.x (such as #50107) which also affect web streams. However, I think I made it work. 🤞