test: move coverage source map tests to new file #55123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
OnlyAviv
added
the
test_runner
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55123 +/- ##
==========================================
- Coverage 88.24% 88.24% -0.01%
==========================================
Files 651 651
Lines 183856 183856
Branches 35853 35852 -1
==========================================
- Hits 162251 162245 -6
- Misses 14896 14899 +3
- Partials 6709 6712 +3 |
MoLow
approved these changes
Sep 29, 2024
OnlyAviv
added
the
author ready
github-actions
bot
removed
the
request-ci
atlowChemi
approved these changes
Sep 30, 2024
cjihrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1d95b79 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55123 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55123 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55123 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
marco-ippolito
added
the
dont-land-on-v20.x
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55123 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the coverage source map tests to their own file / fixture folders.
Why?
Currently, source map support in the test runner has a few bugs (such as...), and with the future bugfixes, additional tests will be added.
The test coverage test file is very large, the additional tests will make it even larger, so this PR moves the sourcemap tests to their own file, so it can expand healthily.