Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V22.10.0 proposal #55343

Merged
merged 230 commits into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
230 commits
Select commit Hold shift + click to select a range
67ecb10
module: fix discrepancy between .ts and .js
marco-ippolito Aug 22, 2024
1de5512
deps: V8: cherry-pick 217457d0a560
targos Sep 11, 2024
eca9668
doc: add documentation for process.features
marco-ippolito Sep 14, 2024
c1d73ab
doc: update documentation for externalizing deps
mhdawson Sep 5, 2024
29866ca
doc: fix typo callsite.lineNumber
RafaelGSS Sep 16, 2024
f332c4c
src: use `Maybe<void>` where bool isn't needed
targos Sep 17, 2024
676d0a0
tools: update github_reporter to 1.7.1
nodejs-github-bot Sep 17, 2024
108cef2
module: remove bogus assertion in CJS entrypoint handling with --import
joyeecheung Aug 27, 2024
0d45365
deps: update corepack to 0.29.4
nodejs-github-bot Sep 17, 2024
f2d74a2
doc: fix history of `process.features`
aduh95 Sep 17, 2024
397ae41
lib: the REPL should survive deletion of Array.prototype methods
ljharb Sep 17, 2024
c89c934
module: refator ESM loader for adding future synchronous hooks
joyeecheung Sep 17, 2024
23b628d
benchmark: add dotenv benchmark
Sep 18, 2024
349d2ed
crypto: add Date fields for `validTo` and `validFrom`
RulerOfCakes Sep 18, 2024
3300d59
os: use const with early return for path
trivikr Sep 18, 2024
ca67c97
meta: add links to alternative issue trackers
Sep 18, 2024
3a5fe95
doc: add missing definitions to `internal-api.md`
Sep 18, 2024
ce0d0c1
meta: remove `build-windows.yml`
Sep 18, 2024
39a728c
doc: change backporting guide with updated info
Sep 18, 2024
a97841e
cli: fix spacing for port range error
Sep 18, 2024
7861ca5
build: print `Running XYZ linter...` for py and yml
Sep 18, 2024
284db53
src: remove duplicate code setting AF_INET
kernelbin Sep 18, 2024
90cce6e
path: remove repetitive conditional operator in `posix.resolve`
HBSPS Sep 18, 2024
048a1ab
cli: ensure --run has proper pwd
anonrig Sep 18, 2024
e1f36d0
meta: remove unneeded ignore rules from ruff
Sep 18, 2024
cb47e16
events: return `currentTarget` when dispatching
KhafraDev Aug 29, 2024
9b78345
test: update DOM events web platform tests
KhafraDev Aug 29, 2024
c8b7a64
Revert "build: upgrade clang-format to v18"
legendecas Sep 18, 2024
1daec9a
test_runner: avoid coverage report partial file names
pmarchini Sep 18, 2024
90a87ca
test: update test to support OpenSSL32
mhdawson Sep 18, 2024
d109f1c
buffer: use simdutf convert_latin1_to_utf8_safe
ronag Sep 18, 2024
1f11d68
test: adjust key sizes to support OpenSSL32
mhdawson Sep 18, 2024
31f0ef6
tools: bump the eslint group in /tools/eslint with 7 updates
dependabot[bot] Sep 19, 2024
9abd1c7
zlib: remove prototype primordials usage
anonrig Sep 19, 2024
fc90d7c
worker: handle `--input-type` more consistently
aduh95 Sep 19, 2024
1d16976
module: report unfinished TLA in ambiguous modules
aduh95 Sep 19, 2024
93c6c90
test_runner: support typescript module mocking
marco-ippolito Sep 19, 2024
4fb2c3b
meta: remove never-used workflow trigger
Sep 19, 2024
62b8640
test: refactor test-whatwg-webstreams-encoding to be shorter
hidaviddong Sep 19, 2024
ce4b6e4
tools: refactor js2c.cc to use c++20
anonrig Sep 19, 2024
d4d5ba3
benchmark: include ascii to fs/readfile
RafaelGSS Sep 19, 2024
30d4722
build,win: float VS 17.11 compilation patch
StefanStojanovic Sep 19, 2024
22b4139
test: remove test-http-max-sockets flaky designation
lpinca Sep 20, 2024
5b012f5
test: move test-http-max-sockets to parallel
lpinca Sep 20, 2024
327a8f7
test: fix invalid wasm test
Sep 20, 2024
4244f1a
doc: add more details for localStorage and sessionStorage
Rekl0w Sep 20, 2024
d7c708a
test_runner: add support for coverage via run()
atlowChemi Sep 20, 2024
98ff615
test: add runner watch mode isolation tests
pmarchini Sep 20, 2024
0876f78
src: add unistd.h import if node posix credentials is defined
JonasBa Sep 20, 2024
f9b19d7
module: write compile cache to temporary file and then rename it
joyeecheung Sep 4, 2024
2dcf70c
module: throw when invalid argument is passed to enableCompileCache()
joyeecheung Sep 17, 2024
06957ff
module: implement flushCompileCache()
joyeecheung Sep 4, 2024
ef546c8
src: cleanup per env handles directly without a list
legendecas Sep 20, 2024
a81f368
build: fix eslint makefile target
Sep 20, 2024
6843ca7
test: add asserts to validate test assumptions
mhdawson Sep 18, 2024
1e53c10
test: fix `soucre` to `source`
Sep 21, 2024
4b962a7
test_runner: replace ansi clear with ansi reset
pmarchini Sep 21, 2024
295f684
tools: update error message for ICU in license-builder
Sep 3, 2024
a929c71
build: add the option to generate compile_commands.json in vcbuild.bat
segevfiner Mar 30, 2024
341b6d9
test: deflake test-http-header-overflow
lpinca Sep 17, 2024
f7c3b03
lib: propagate aborted state to dependent signals before firing events
jazelly Sep 8, 2024
be2fe4b
events: allow null/undefined eventInitDict
KhafraDev Aug 29, 2024
20d3a80
test: remove unused common utilities
avivkeller Sep 7, 2024
79ffefa
fs: convert to u8 string for filesystem path
jazelly Sep 20, 2024
9506f77
test: remove `getCallSite` from common
avivkeller Sep 14, 2024
3077f6a
build: support up to python 3.13 in android-configure
avivkeller Aug 23, 2024
a679669
test: improve coverage for timer promises schedular
avivkeller Jun 6, 2024
a9fa2da
zlib: throw brotli initialization error from c++
anonrig Sep 1, 2024
d264639
util: update ansi regex
Sep 9, 2024
22e601a
test: add `util.stripVTControlCharacters` test
avivkeller Sep 9, 2024
465d050
src: mark node --run as stable
anonrig Sep 20, 2024
449dad0
test_runner: use `test:` symbol on second print of parent test
avivkeller Sep 15, 2024
9ae80e1
src: revert filesystem::path changes
anonrig Sep 21, 2024
b62f2f8
test_runner: add 'test:summary' event
cjihrig Sep 21, 2024
6d42e44
test: adjust tls-set-ciphers for OpenSSL32
mhdawson Sep 21, 2024
516c775
doc: cover --experimental-test-module-mocks flag
textbook Sep 21, 2024
b3e0490
doc: add missing EventSource docs to globals
KhafraDev Sep 22, 2024
aeae597
meta: add `linux` to OS labels in collaborator guide
Sep 22, 2024
b6fc9ad
module: remove duplicated import
Sep 22, 2024
c56e324
test: fix `test-vm-context-dont-contextify` when path contains a space
aduh95 Sep 22, 2024
a50dd21
test: do not assume `process.execPath` contains no spaces
aduh95 Sep 22, 2024
1c00155
test,crypto: update WebCryptoAPI WPT
panva Sep 22, 2024
268f1ec
test: update tls test to support OpenSSL32
mhdawson Sep 22, 2024
89aeae6
doc: remove `parseREPLKeyword` from REPL documentation
Sep 22, 2024
43bbca2
test: make `test-runner-assert` more robust
Sep 22, 2024
8818c6c
test_runner: report error on missing sourcemap source
Sep 23, 2024
d3dfbe7
build: display free disk space after build in the test-macOS workflow
iwuliz Sep 20, 2024
d99ae54
build: remove -v flag to reduce noise
iwuliz Sep 20, 2024
3a1485a
src: move evp stuff to ncrypto
jasnell Sep 12, 2024
452bc9b
benchmark: add webstorage benchmark
jakecastelli Sep 23, 2024
d3f8c35
crypto: ensure invalid SubtleCrypto JWK data import results in DataError
panva Sep 23, 2024
d4873bc
lib: remove lib/internal/idna.js
anonrig Sep 23, 2024
a97c80c
doc: add note about `--expose-internals`
Sep 23, 2024
65c376a
tools: remove redudant code from eslint require rule
Sep 23, 2024
93c23e7
test: deflake test-inspector-strip-types
lpinca Sep 24, 2024
173464d
deps: update acorn-walk to 8.3.4
nodejs-github-bot Sep 24, 2024
80da599
test: remove interval and give more time to unsync
pmarchini Sep 24, 2024
f3ca9c6
build: update ruff and add `lint-py-fix`
Sep 24, 2024
bebc95e
doc: add abmusse to collaborators
abmusse Sep 23, 2024
cbfc980
perf_hooks: add missing type argument to getEntriesByName
luketaher Sep 24, 2024
d803355
lib: prefer optional chaining
Sep 24, 2024
0f01f38
tty: fix links for terminal colors
Sep 24, 2024
68822cc
build: add more information to Makefile help
Sep 24, 2024
3304bf3
tools: unlock versions of irrelevant DB deps
targos Sep 24, 2024
bf69ae1
stream: set stream prototype to closest transferable superclass
jazelly Sep 24, 2024
111261e
module: implement the "module-sync" exports condition
joyeecheung Sep 25, 2024
538b1eb
repl: catch `\v` and `\r` in new-line detection
Sep 25, 2024
566179c
lib, tools: remove duplicate requires
Sep 25, 2024
36c9ea8
Revert "test: mark test-fs-watch-non-recursive flaky on Windows"
lpinca Sep 25, 2024
73b05cf
doc: correct `cleanup` option in stream.(promises.)finished
Renegade334 Sep 25, 2024
bf7d7ae
lib: fix typos
NathanBaulch Sep 25, 2024
1fc8ede
src: update clang-tidy and focus on modernization
anonrig Sep 25, 2024
4352d9c
benchmark: create benchmark for typescript
marco-ippolito Sep 25, 2024
fdae57f
test: fix some tests when path contains `%`
aduh95 Sep 25, 2024
7eaeba4
test_runner: fix mocking modules with quote in their URL
aduh95 Sep 25, 2024
93b215d
meta: add more information about nightly releases
Sep 25, 2024
85f1187
test: fix `assertSnapshot` when path contains a quote
aduh95 Sep 25, 2024
b885f05
test: fix more tests that fail when path contains a space
aduh95 Sep 25, 2024
e879c5e
test: fix test-tls-junk-closes-server
mhdawson Sep 25, 2024
ee0a98b
src: decode native error messages as UTF-8
joyeecheung Sep 25, 2024
fb8470a
test: deflake test-http-remove-header-stays-removed
lpinca Sep 26, 2024
3a6e724
buffer: extract Blob's .arrayBuffer() & webidl changes
KhafraDev Sep 26, 2024
b0636a1
deps: update timezone to 2024b
nodejs-github-bot Sep 26, 2024
b7b1fa6
tools: bump Rollup from 4.18.1 to 4.22.4 for `lint-md`
dependabot[bot] Sep 26, 2024
12c9d97
doc: add missing `:` to `run()`'s `globPatterns`
Sep 26, 2024
a96d5d1
src: move more stuff over to use Maybe<void>
jasnell Sep 7, 2024
fd40f08
doc: update style guide
Sep 26, 2024
e99d4a4
test: deflake test/pummel/test-timers.js
jakecastelli Sep 27, 2024
32261fc
module: support loading entrypoint as url
avivkeller Sep 13, 2024
0999b5e
test: remove duplicated test descriptions
unseen1980 Sep 27, 2024
0fb446e
esm: do not interpret `"main"` as a URL
aduh95 Sep 27, 2024
a9675a0
stream: treat null asyncIterator as undefined
jazelly Sep 27, 2024
8ad0dff
doc: fix the require resolve algorithm in `modules.md`
chirsz-ever Sep 27, 2024
706e961
src: fix typos
NathanBaulch Sep 27, 2024
d7a9df6
build: notify via slack when review-wanted
RafaelGSS Sep 27, 2024
7186ede
doc: put --env-file-if-exists=config right under --env-file=config
geeksilva97 Sep 28, 2024
0bb5584
src: add receiver to fast api callback methods
Ceres6 Sep 28, 2024
b12b4a2
doc: remove random horizontal separators in `process.md`
aduh95 Sep 28, 2024
60a35ed
tools: make `choco install` script more readable
Sep 28, 2024
1dcc5ee
Revert "console: colorize console error and warn"
Sep 28, 2024
1c94725
fs: check subdir correctly in cpSync
jazelly Sep 28, 2024
6cc4951
doc: move the YAML changes element
sendoru Sep 28, 2024
86f7cb8
test_runner: support custom arguments in `run()`
Sep 28, 2024
9aeba48
test: fix typos
NathanBaulch Sep 28, 2024
19cfa31
test_runner: close and flush destinations on forced exit
cjihrig Sep 28, 2024
bb34990
doc: remove outdated https import reference
geeksilva97 Sep 28, 2024
e361951
assert: show the diff when deep comparing data with a custom message
puskin94 Sep 4, 2024
61b9ed3
doc: add esm examples to node:net
mfdebian Sep 28, 2024
942ad54
src: move more key handling to ncrypto
jasnell Sep 28, 2024
7982d3d
tools: only check teams on the default branch
aduh95 Sep 28, 2024
1240197
test_runner: support typescript files in default glob
Sep 29, 2024
b1ebb0d
buffer: coerce extrema to int in `blob.slice`
aduh95 Sep 29, 2024
cc88382
test: remove unnecessary `await` in test-watch-mode
iwuliz Sep 29, 2024
c308862
test_runner: avoid spread operator on arrays
aduh95 Sep 29, 2024
65fbe94
test: add `escapePOSIXShell` util
aduh95 Sep 29, 2024
781ffd8
doc: fix link in `test/README.md`
LiviaMedeiros Sep 30, 2024
914db60
http2: expose nghttp2_option_set_stream_reset_rate_limit as an option
arcanis Sep 30, 2024
a57c8ba
test: update wpt test for encoding
Nahee-Park Sep 30, 2024
b229083
src: parse --stack-trace-limit and use it in --trace-* flags
joyeecheung Sep 25, 2024
1af5ad6
src: fixup Error.stackTraceLimit during snapshot building
joyeecheung Sep 25, 2024
aaea394
build,win: add winget config to set up env
huseyinacacak-janea Sep 30, 2024
c7ed2ff
stream: handle undefined chunks correctly in decode stream
Nahee-Park Sep 30, 2024
d6bcc44
src: modernize likely/unlikely hints
anonrig Sep 30, 2024
cd0795f
benchmark: add no-warnings to process.has bench
RafaelGSS Sep 30, 2024
fa695fa
watch: preserve output when gracefully restarted
theoludwig Sep 30, 2024
1985d90
meta: add mailmap entry for abmusse
abmusse Sep 30, 2024
7c9ceab
doc: use correct dash in stability status
aduh95 Oct 1, 2024
286ea4e
doc: mention addons to experimental permission
RafaelGSS Oct 1, 2024
ce67e7b
test: adding more tests for strip-types
kevinuehara Oct 2, 2024
8a57550
doc: fix unordered error anchors
aduh95 Oct 2, 2024
b1d47d0
src: apply getCallSite optimization
RafaelGSS Sep 30, 2024
0412ac8
module: add internal type def for `flushCompileCache`
JakobJingleheimer Oct 3, 2024
d65334c
worker: throw InvalidStateError in postMessage after close
Nahee-Park Oct 3, 2024
dbfae3f
fs: acknowledge `signal` option in `filehandle.createReadStream()`
LiviaMedeiros Oct 3, 2024
7ddbfe8
doc: update test context.assert
pmarchini Oct 3, 2024
f89664d
build: include `.nycrc` in coverage workflows
iwuliz Oct 3, 2024
1b30f7f
test: move coverage source map tests to new file
Oct 3, 2024
297cb0d
doc: tweak onboarding instructions
mhdawson Oct 3, 2024
f5b4ae5
meta: bump peter-evans/create-pull-request from 7.0.1 to 7.0.5
dependabot[bot] Oct 3, 2024
33be199
meta: bump actions/setup-node from 4.0.3 to 4.0.4
dependabot[bot] Oct 3, 2024
0f4269f
meta: bump actions/checkout from 4.1.7 to 4.2.0
dependabot[bot] Oct 3, 2024
c988e7e
tools: bump the eslint group in /tools/eslint with 4 updates
dependabot[bot] Oct 3, 2024
75073c5
quic: start adding in the internal quic js api
jasnell Jun 2, 2024
295c17c
src: make minor tweaks to quic c++ for c++20
jasnell Sep 28, 2024
0d93b1e
build: fix not valid json in coverage
jakecastelli Sep 30, 2024
283927e
deps: upgrade openssl sources to quictls/openssl-3.0.14+quic1
nodejs-github-bot Aug 12, 2024
29e6484
deps: update archs files for openssl-3.0.14+quic1
nodejs-github-bot Aug 12, 2024
63d51c8
deps: upgrade openssl sources to quictls/openssl-3.0.15+quic1
nodejs-github-bot Sep 30, 2024
bb9f77d
deps: update archs files for openssl-3.0.15+quic1
nodejs-github-bot Sep 30, 2024
b36f8c2
test: update multiple assert tests to use node:test
jasnell Aug 27, 2024
5fda4a1
worker: add `markAsUncloneable` api
jazelly Oct 4, 2024
d7b73bb
meta: bump mozilla-actions/sccache-action from 0.0.5 to 0.0.6
dependabot[bot] Oct 4, 2024
8eae0d3
doc: fix initial default value of autoSelectFamily
freego555 Oct 5, 2024
4050f68
process: add `process.features.typescript`
Oct 5, 2024
195df65
doc: move `ERR_NAPI_TSFN_START/STOP_IDLE_LOOP` to legacy errors
aduh95 Oct 5, 2024
0999949
src: handle errors correctly in webstorage
targos Aug 26, 2024
2f65b3f
deps: V8: partially cherry-pick 8953e49478
bnoordhuis Oct 5, 2024
b533a51
deps: V8: backport 0d5d6e71bbb0
anonrig Sep 20, 2024
5d41b8a
doc: update `require(ESM)` history and stability status
aduh95 Oct 2, 2024
f703652
deps: upgrade npm to 10.9.0
npm-cli-bot Oct 5, 2024
67f5f46
sqlite: enable foreign key constraints by default
tniessen Oct 6, 2024
c126543
sqlite: make sourceSQL and expandedSQL string-valued properties
tniessen Oct 6, 2024
f0b4412
crypto: add KeyObject.prototype.toCryptoKey
panva Oct 6, 2024
0f7e3f0
test_runner: assert entry is a valid object
geeksilva97 Oct 6, 2024
800f7c4
test_runner: throw on invalid source map
Oct 6, 2024
ea7aaf3
v8: out of bounds copy
ronag Oct 7, 2024
1b1104e
test: add resource to internal module stat test
RafaelGSS Sep 28, 2024
77f8a3f
build: fix notify-on-review-wanted action
RafaelGSS Oct 7, 2024
6a7d201
tools: update gyp-next to 0.18.2
nodejs-github-bot Oct 8, 2024
17d2f9d
test: make `test-loaders-workers-spawned` less flaky
aduh95 Oct 8, 2024
85b7659
doc: add onboarding details for ambassador program
marco-ippolito Oct 8, 2024
08b5e6c
lib: fix module print timing when specifier includes `"`
aduh95 Oct 8, 2024
d51e5a8
tools: enforce errors to not be documented in legacy section
Oct 8, 2024
57a9d3f
sqlite: disable DQS misfeature by default
tniessen Oct 8, 2024
c9a1bbb
meta: move one or more collaborators to emeritus
nodejs-github-bot Oct 9, 2024
b03272b
doc: fix `events.once()` example using `AbortSignal`
foxxyz Oct 9, 2024
263526d
benchmark: rewrite detect-esm-syntax benchmark
joyeecheung Oct 9, 2024
707e7cc
doc: add pmarchini to collaborators
pmarchini Oct 9, 2024
8735888
Revert "doc: update test context.assert"
aduh95 Oct 9, 2024
5ea8aa1
doc: fix Markdown linter
aduh95 Oct 9, 2024
6fcac73
module: wrap swc error in ERR_INVALID_TYPESCRIPT_SYNTAX
marco-ippolito Oct 10, 2024
d8e42be
doc: move `ERR_INVALID_PERFORMANCE_MARK` to legacy errors
aduh95 Oct 10, 2024
1921d7a
doc: add release key for aduh95
aduh95 Oct 10, 2024
ff3cc3b
test: use more informative errors in `test-runner-cli`
aduh95 Oct 10, 2024
34ca36a
deps: update undici to 6.20.0
nodejs-github-bot Oct 10, 2024
3273707
test: fix tests when Amaro is unavailable
richardlau Oct 11, 2024
0655d3a
process: fix `process.features.typescript` when Amaro is unavailable
aduh95 Oct 11, 2024
39c7a9e
benchmark: adjust config for deepEqual object
RafaelGSS Oct 11, 2024
e95163b
process: add process.features.require_module
joyeecheung Oct 7, 2024
afe4bc6
2024-10-16, Version 22.10.0 (Current)
aduh95 Oct 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions .clang-format
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ AlignEscapedNewlines: Right
AlignOperands: true
AlignTrailingComments: true
AllowAllParametersOfDeclarationOnNextLine: true
AllowShortBlocksOnASingleLine: Never
AllowShortBlocksOnASingleLine: false
AllowShortCaseLabelsOnASingleLine: false
AllowShortFunctionsOnASingleLine: Inline
AllowShortIfStatementsOnASingleLine: true
AllowShortLoopsOnASingleLine: false
AllowShortLoopsOnASingleLine: true
AlwaysBreakAfterDefinitionReturnType: None
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: false
Expand Down
54 changes: 54 additions & 0 deletions .configurations/configuration.dsc.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# yaml-language-server: $schema=https://aka.ms/configuration-dsc-schema/0.2
# Reference: https://github.com/nodejs/node/blob/main/BUILDING.md#windows
properties:
resources:
- resource: Microsoft.WinGet.DSC/WinGetPackage
id: pythonPackage
directives:
description: Install Python 3.12
module: Microsoft.WinGet.DSC
allowPrerelease: true
settings:
id: Python.Python.3.12
source: winget
- resource: Microsoft.WinGet.DSC/WinGetPackage
id: vsPackage
directives:
description: Install Visual Studio 2022 Community
allowPrerelease: true
settings:
id: Microsoft.VisualStudio.2022.Community
source: winget
useLatest: true
- resource: Microsoft.VisualStudio.DSC/VSComponents
id: vsComponents
dependsOn:
- vsPackage
directives:
description: Install required VS workloads and components
allowPrerelease: true
settings:
productId: Microsoft.VisualStudio.Product.Community
channelId: VisualStudio.17.Release
includeRecommended: true
components:
- Microsoft.VisualStudio.Workload.NativeDesktop
- Microsoft.VisualStudio.Component.VC.Llvm.Clang
- Microsoft.VisualStudio.Component.VC.Llvm.ClangToolset
- resource: Microsoft.WinGet.DSC/WinGetPackage
id: gitPackage
directives:
description: Install Git
allowPrerelease: true
settings:
id: Git.Git
source: winget
- resource: Microsoft.WinGet.DSC/WinGetPackage
id: nasmPackage
directives:
description: Install NetWide Assembler (NASM)
allowPrerelease: true
settings:
id: Nasm.Nasm
source: winget
configurationVersion: 0.1.0
54 changes: 54 additions & 0 deletions .configurations/configuration.vsEnterprise.dsc.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# yaml-language-server: $schema=https://aka.ms/configuration-dsc-schema/0.2
# Reference: https://github.com/nodejs/node/blob/main/BUILDING.md#windows
properties:
resources:
- resource: Microsoft.WinGet.DSC/WinGetPackage
id: pythonPackage
directives:
description: Install Python 3.12
module: Microsoft.WinGet.DSC
allowPrerelease: true
settings:
id: Python.Python.3.12
source: winget
- resource: Microsoft.WinGet.DSC/WinGetPackage
id: vsPackage
directives:
description: Install Visual Studio 2022 Enterprise
allowPrerelease: true
settings:
id: Microsoft.VisualStudio.2022.Enterprise
source: winget
useLatest: true
- resource: Microsoft.VisualStudio.DSC/VSComponents
id: vsComponents
dependsOn:
- vsPackage
directives:
description: Install required VS workloads and components
allowPrerelease: true
settings:
productId: Microsoft.VisualStudio.Product.Enterprise
channelId: VisualStudio.17.Release
includeRecommended: true
components:
- Microsoft.VisualStudio.Workload.NativeDesktop
- Microsoft.VisualStudio.Component.VC.Llvm.Clang
- Microsoft.VisualStudio.Component.VC.Llvm.ClangToolset
- resource: Microsoft.WinGet.DSC/WinGetPackage
id: gitPackage
directives:
description: Install Git
allowPrerelease: true
settings:
id: Git.Git
source: winget
- resource: Microsoft.WinGet.DSC/WinGetPackage
id: nasmPackage
directives:
description: Install NetWide Assembler (NASM)
allowPrerelease: true
settings:
id: Nasm.Nasm
source: winget
configurationVersion: 0.1.0
54 changes: 54 additions & 0 deletions .configurations/configuration.vsProfessional.dsc.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# yaml-language-server: $schema=https://aka.ms/configuration-dsc-schema/0.2
# Reference: https://github.com/nodejs/node/blob/main/BUILDING.md#windows
properties:
resources:
- resource: Microsoft.WinGet.DSC/WinGetPackage
id: pythonPackage
directives:
description: Install Python 3.12
module: Microsoft.WinGet.DSC
allowPrerelease: true
settings:
id: Python.Python.3.12
source: winget
- resource: Microsoft.WinGet.DSC/WinGetPackage
id: vsPackage
directives:
description: Install Visual Studio 2022 Professional
allowPrerelease: true
settings:
id: Microsoft.VisualStudio.2022.Professional
source: winget
useLatest: true
- resource: Microsoft.VisualStudio.DSC/VSComponents
id: vsComponents
dependsOn:
- vsPackage
directives:
description: Install required VS workloads and components
allowPrerelease: true
settings:
productId: Microsoft.VisualStudio.Product.Professional
channelId: VisualStudio.17.Release
includeRecommended: true
components:
- Microsoft.VisualStudio.Workload.NativeDesktop
- Microsoft.VisualStudio.Component.VC.Llvm.Clang
- Microsoft.VisualStudio.Component.VC.Llvm.ClangToolset
- resource: Microsoft.WinGet.DSC/WinGetPackage
id: gitPackage
directives:
description: Install Git
allowPrerelease: true
settings:
id: Git.Git
source: winget
- resource: Microsoft.WinGet.DSC/WinGetPackage
id: nasmPackage
directives:
description: Install NetWide Assembler (NASM)
allowPrerelease: true
settings:
id: Nasm.Nasm
source: winget
configurationVersion: 0.1.0
2 changes: 1 addition & 1 deletion .cpplint
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
set noparent
filter=-build/include_alpha,-build/include_subdir,-build/include_what_you_use,-legal/copyright,-readability/nolint
filter=-build/include_alpha,-build/include_subdir,-build/include_what_you_use,-legal/copyright,-readability/nolint,-readability/braces
linelength=80
8 changes: 7 additions & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
blank_issues_enabled: true
contact_links:
- name: ⁉️ Need help with Node.js?
- name: ⁉️ Need general help with Node.js?
url: https://github.com/nodejs/help
about: Please file an issue in our help repo.
- name: 📦 Have an issue with npm?
url: https://github.com/npm/cli/issues
about: npm has a seperate issue tracker.
- name: 📡 Have an issue with undici? (`WebSocket`, `fetch`, etc.)
url: https://github.com/nodejs/undici/issues
about: Undici has a seperate issue tracker.
- name: 🌐 Found a problem with nodejs.org beyond the API reference docs?
url: https://github.com/nodejs/nodejs.org/issues/new/choose
about: Please file an issue in the Node.js website repo.
4 changes: 2 additions & 2 deletions .github/workflows/auto-start-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ jobs:
if: needs.get-prs-for-ci.outputs.numbers != ''
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
with:
persist-credentials: false

- name: Install Node.js
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
uses: mozilla-actions/sccache-action@89e9040de88b577a072e3760aaf59f585da083af # v0.0.5
uses: mozilla-actions/sccache-action@9e326ebed976843c9932b3aa0e021c6f50310eb4 # v0.0.6
with:
version: v0.8.1
- name: Environment Information
Expand All @@ -72,15 +72,15 @@ jobs:
needs: build-tarball
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
uses: mozilla-actions/sccache-action@89e9040de88b577a072e3760aaf59f585da083af # v0.0.5
uses: mozilla-actions/sccache-action@9e326ebed976843c9932b3aa0e021c6f50310eb4 # v0.0.6
with:
version: v0.8.1
- name: Environment Information
Expand Down
53 changes: 0 additions & 53 deletions .github/workflows/build-windows.yml

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/commit-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
run: |
echo "plusOne=$((${{ github.event.pull_request.commits }} + 1))" >> $GITHUB_OUTPUT
echo "minusOne=$((${{ github.event.pull_request.commits }} - 1))" >> $GITHUB_OUTPUT
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
with:
fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}
persist-credentials: false
- run: git reset HEAD^2
- name: Install Node.js
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
with:
node-version: ${{ env.NODE_VERSION }}
- name: Validate commit message
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/commit-queue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
if: needs.get_mergeable_prs.outputs.numbers != ''
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
with:
# Needs the whole git history for ncu to work
# See https://github.com/nodejs/node-core-utils/pull/486
Expand All @@ -71,7 +71,7 @@ jobs:

# Install dependencies
- name: Install Node.js
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
with:
node-version: ${{ env.NODE_VERSION }}
- name: Install @node-core/utils
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/coverage-linux-without-intl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ on:
- tools/test.py
- .github/workflows/coverage-linux-without-intl.yml
- codecov.yml
- .nycrc
push:
branches:
- main
Expand All @@ -26,6 +27,7 @@ on:
- tools/test.py
- .github/workflows/coverage-linux-without-intl.yml
- codecov.yml
- .nycrc

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand All @@ -46,15 +48,15 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
uses: mozilla-actions/sccache-action@89e9040de88b577a072e3760aaf59f585da083af # v0.0.5
uses: mozilla-actions/sccache-action@9e326ebed976843c9932b3aa0e021c6f50310eb4 # v0.0.6
with:
version: v0.8.1
- name: Environment Information
Expand Down
Loading
Loading