-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
child_process: fix parsing messages with splitted length field #56106
base: main
Are you sure you want to change the base?
Conversation
Hey! Amazing, nice patch, thank you. Could you please add a test for it? |
@juanarbol I've written a test where the child process sends messages to the main, and the third message is split into parts so that the header with the length of the message is split too, which leads to the problem in the current version but my patch solves it |
test/parallel/test-child-process-advanced-serialization-splitted-length-field.js
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56106 +/- ##
==========================================
+ Coverage 88.01% 88.53% +0.51%
==========================================
Files 656 657 +1
Lines 188982 190208 +1226
Branches 35997 36527 +530
==========================================
+ Hits 166330 168396 +2066
+ Misses 15825 14995 -830
+ Partials 6827 6817 -10
|
…ed-length-field.js Co-authored-by: Luigi Pinca <[email protected]>
Co-authored-by: Luigi Pinca <[email protected]>
Co-authored-by: Luigi Pinca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes: #55834