test: remove hasOpenSSL3x utils
#56164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In favor of `hasOpenSSL`.
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Dec 7, 2024
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56164 +/- ##
=======================================
Coverage 88.00% 88.00%
=======================================
Files 656 656
Lines 189131 189133 +2
Branches 36009 36005 -4
=======================================
+ Hits 166439 166450 +11
- Misses 15853 15855 +2
+ Partials 6839 6828 -11 |
richardlau
approved these changes
Dec 7, 2024
aduh95
added
author ready
juanarbol
approved these changes
Dec 9, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3851edf |
aduh95
added a commit
that referenced
this pull request
Dec 10, 2024
In favor of `hasOpenSSL`. PR-URL: #56164 Refs: https://github.com/nodejs/node/pull/56160/files#r1874118863 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favor of
hasOpenSSL.Originally posted by @richardlau in #56160 (comment)
Let's remove those before the list grows larger.
Refs: https://github.com/nodejs/node/pull/56160/files#r1874118863