-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert: make Maps be partially compared in partialDeepStrictEqual #56195
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
puskin94:partially-compare-maps
Dec 11, 2024
Merged
assert: make Maps be partially compared in partialDeepStrictEqual #56195
nodejs-github-bot
merged 1 commit into
nodejs:main
from
puskin94:partially-compare-maps
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
Issues and PRs related to the assert subsystem.
needs-ci
PRs that need a full CI run.
labels
Dec 9, 2024
BridgeAR
approved these changes
Dec 9, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 9, 2024
pmarchini
approved these changes
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56195 +/- ##
=======================================
Coverage 88.49% 88.50%
=======================================
Files 656 656
Lines 189261 189265 +4
Branches 36348 36351 +3
=======================================
+ Hits 167493 167508 +15
+ Misses 14977 14966 -11
Partials 6791 6791
|
puskin94
force-pushed
the
partially-compare-maps
branch
from
December 9, 2024 16:41
58f4c61
to
fa9beaf
Compare
aduh95
approved these changes
Dec 10, 2024
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 10, 2024
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 10, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 11, 2024
Landed in 9ec8b9e |
targos
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #56195 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
assert
Issues and PRs related to the assert subsystem.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other PR aiming to make the
assert.partialDeepStrictEqual
function more complete.Since the introduction of the function in here the
Map
comparison has been introduced asstrict
, making examples as the following not possible (e.g.expected
is a subset ofactual
):This PR makes
assert.partialDeepStrictEqual
work with partial Map comparisons