Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-abortsignal-drop-settled-signals flakiness #56197

Merged
merged 1 commit into from
Dec 12, 2024
Merged

test: fix test-abortsignal-drop-settled-signals flakiness #56197

merged 1 commit into from
Dec 12, 2024

Conversation

geeksilva97
Copy link
Contributor

@geeksilva97 geeksilva97 commented Dec 9, 2024 •
edited
Loading

Refs #56190
Fixes #56190

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 9, 2024
@geeksilva97 geeksilva97 marked this pull request as ready for review December 9, 2024 15:55
@targos
Copy link
Member

targos commented Dec 9, 2024

This fixes the flakiness on my end:
CleanShot 2024-12-09 at 17 06 16

@geeksilva97
Copy link
Contributor Author

This fixes the flakiness on my end: CleanShot 2024-12-09 at 17 06 16

Thanks a lot, @targos . Will use it.

@geeksilva97 geeksilva97 requested a review from targos December 9, 2024 17:10
@geeksilva97 geeksilva97 changed the title test: increase gc calls to ensure objects are cleaned test: improve gc calls to fix flakiness Dec 9, 2024
@geeksilva97 geeksilva97 changed the title test: improve gc calls to fix flakiness test: fix flakiness by improving gc calls Dec 9, 2024
@geeksilva97 geeksilva97 changed the title test: fix flakiness by improving gc calls test: improve gc calls to fix flakiness Dec 9, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (3851edf) to head (f735620).
Report is 37 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56197      +/-   ##
==========================================
+ Coverage   88.49%   88.53%   +0.03%     
==========================================
  Files         656      657       +1     
  Lines      189261   189880     +619     
  Branches    36348    36458     +110     
==========================================
+ Hits       167493   168106     +613     
- Misses      14977    14983       +6     
  Partials     6791     6791

see 31 files with indirect coverage changes

@jazelly jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63970/

@jazelly jazelly added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Dec 10, 2024
@aduh95 aduh95 added needs-ci PRs that need a full CI run. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 10, 2024
@aduh95
Copy link
Contributor

aduh95 commented Dec 10, 2024

Is the first commit message still correct to describe this PR?

@geeksilva97
Copy link
Contributor Author

Is the first commit message still correct to describe this PR?

Good point. I think it's not accurate. The two latest commits in this PR describe it better.

@aduh95 aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2024
@geeksilva97 geeksilva97 force-pushed the fix-flaky-abort-signal-test branch from 04e5a4b to f735620 Compare December 11, 2024 13:05
@geeksilva97
Copy link
Contributor Author

Is the first commit message still correct to describe this PR?

Fixed it, @aduh95

@geeksilva97 geeksilva97 changed the title test: improve gc calls to fix flakiness test: fix test-abortsignal-drop-settled-signals flakiness Dec 11, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64009/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64018/

@atlowChemi atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2024
@nodejs-github-bot nodejs-github-bot merged commit 743eacc into nodejs:main Dec 12, 2024
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 743eacc

targos pushed a commit that referenced this pull request Dec 13, 2024
@geeksilva97 @targos
test: fix test-abortsignal-drop-settled-signals flakiness
c2fb3a7 
PR-URL: #56197
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung left review comments

@atlowChemi atlowChemi atlowChemi approved these changes

@jazelly jazelly jazelly approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parallel/test-abortsignal-drop-settled-signals is flaky
10 participants
@geeksilva97 @targos @nodejs-github-bot @aduh95 @jasnell @lpinca @joyeecheung @BridgeAR @jazelly @atlowChemi