build: add major release action #56199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
|
Adding blocked label as I'm still testing it on my local fork. |
RafaelGSS
force-pushed
the
add-major-release-reminder-action
branch
2 times, most recently
from
5739718 to
9bc5c7f
Compare
|
All good! See RafaelGSS/test-reminder-action#5. cc: @nodejs/releasers |
This action reminds collaborators of the upcoming major release date. In the future, this action can also update and create the branches (that's why the action name is generic).
RafaelGSS
force-pushed
the
add-major-release-reminder-action
branch
from
9bc5c7f to
16f4763
Compare
aduh95
reviewed
Dec 10, 2024
aduh95
reviewed
Dec 10, 2024
aduh95
reviewed
Dec 10, 2024
aduh95
reviewed
Dec 10, 2024
aduh95
reviewed
Dec 11, 2024
aduh95
reviewed
Dec 11, 2024
aduh95
reviewed
Dec 11, 2024
aduh95
reviewed
Dec 11, 2024
aduh95
reviewed
Dec 11, 2024
aduh95
approved these changes
Dec 12, 2024
RafaelGSS
added
author ready
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56199 ✔ Done loading data for nodejs/node/pull/56199 ----------------------------------- PR info ------------------------------------ Title build: add major release action (#56199) Author Rafael Gonzaga <[email protected]> (@RafaelGSS) Branch RafaelGSS:add-major-release-reminder-action -> nodejs:main Labels meta, author ready, commit-queue-squash Commits 5 - build: add major release action - fixup! build: add major release action - fixup! fixup! build: add major release action - fixup! fixup! fixup! build: add major release action - fixup! apply cr suggestion Committers 1 - RafaelGSS <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56199 Refs: https://github.com/nodejs/node/pull/55732 Reviewed-By: Antoine du Hamel <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56199 Refs: https://github.com/nodejs/node/pull/55732 Reviewed-By: Antoine du Hamel <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 09 Dec 2024 18:14:17 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/56199#pullrequestreview-2499793050 ✘ This PR needs to wait 99 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12298458190 |
bnb
reviewed
Dec 12, 2024
Co-authored-by: Tierney Cyren <[email protected]>
RafaelGSS
removed
the
commit-queue-failed
aduh95
reviewed
Dec 14, 2024
aduh95
reviewed
Dec 14, 2024
aduh95
reviewed
Dec 14, 2024
Co-authored-by: Antoine du Hamel <[email protected]>
|
@aduh95 can you re-approve after the recent changes? |
aduh95
approved these changes
Dec 16, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in fb5bc18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action reminds collaborators of the upcoming
major release date. In the future, this action can
also update and create the branches (that's why the
action name is generic).
Refs: #55732