-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v22.x backport] util: add sourcemap support to getCallSites #56209
Closed
marco-ippolito
wants to merge
1
commit into
nodejs:v22.x-staging
from
marco-ippolito:backport-util-callsite-sourcemap
Closed
[v22.x backport] util: add sourcemap support to getCallSites #56209
marco-ippolito
wants to merge
1
commit into
nodejs:v22.x-staging
from
marco-ippolito:backport-util-callsite-sourcemap
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs#55589 Fixes: nodejs#55109 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Review requested:
|
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
v22.x
v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
labels
Dec 10, 2024
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Dec 10, 2024
aduh95
approved these changes
Dec 10, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 10, 2024
mertcanaltin
approved these changes
Dec 12, 2024
RafaelGSS
approved these changes
Dec 13, 2024
ljharb
approved these changes
Dec 13, 2024
UlisesGascon
approved these changes
Dec 13, 2024
aduh95
force-pushed
the
v22.x-staging
branch
from
December 13, 2024 23:32
9fcea1b
to
1377528
Compare
marco-ippolito
added a commit
that referenced
this pull request
Dec 14, 2024
PR-URL: #55589 Backport-PR-URL: #56209 Fixes: #55109 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Landed in 2dd61ae |
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
PR-URL: #55589 Backport-PR-URL: #56209 Fixes: #55109 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
v22.x
v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #55589
Fixes: #55109
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Chengzhong Wu [email protected]