Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert bdb6d12 and add test case for listeners #56282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revert bdb6d12 and add test case for listeners #56282

wants to merge 2 commits into from
+17 −12

Conversation

origranot
Copy link

According to the conversations here, I reverted the old commit and added another test case.

@nodejs-github-bot nodejs-github-bot added events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run. labels Dec 17, 2024
@origranot origranot mentioned this pull request Dec 17, 2024
Open
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64077/

@jazelly jazelly added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Dec 17, 2024
@lpinca
Copy link
Member

lpinca commented Dec 17, 2024

@origranot please remove the merge commit.

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.56%. Comparing base (a50f3d5) to head (7a4a78d).
Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56282      +/-   ##
==========================================
+ Coverage   88.55%   88.56%   +0.01%     
==========================================
  Files         657      657              
  Lines      190243   190265      +22     
  Branches    36536    36545       +9     
==========================================
+ Hits       168461   168503      +42     
+ Misses      14963    14955       -8     
+ Partials     6819     6807      -12
Files with missing lines Coverage Δ
lib/events.js 99.75% <100.00%> (-0.09%) ⬇️

... and 30 files with indirect coverage changes

@origranot
Copy link
Author

@origranot please remove the merge commit.

Done

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64086/

@origranot
Copy link
Author

origranot commented Dec 18, 2024 •
edited
Loading

@lpinca Any reason the build pipelines are failing?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64096/

@lpinca
Copy link
Member

lpinca commented Dec 18, 2024

#54918 and flaky tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazelly jazelly jazelly approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@origranot @nodejs-github-bot @lpinca @jazelly