Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix node: enforcement for docs #56284

Merged
merged 1 commit into from
Dec 17, 2024
Merged

tools: fix node: enforcement for docs #56284

merged 1 commit into from
Dec 17, 2024
+3 −1

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 17, 2024

Refs: #56185

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 17, 2024
@aduh95 aduh95 mentioned this pull request Dec 17, 2024
Merged
@targos targos linked an issue Dec 17, 2024 that may be closed by this pull request
make lint failed on main #56279
Closed
@legendecas legendecas mentioned this pull request Dec 17, 2024
Closed
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 17, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6012a4e into nodejs:main Dec 17, 2024
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6012a4e

@aduh95 aduh95 deleted the node-prefix-enforcement branch December 17, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make lint failed on main
5 participants
@aduh95 @nodejs-github-bot @lpinca @targos @legendecas