Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner,cli: mark test isolation as stable #56298

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test_runner,cli: mark test isolation as stable #56298

wants to merge 2 commits into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 17, 2024

This commit stabilizes test isolation configuration in the test runner.

@cjihrig
test_runner,cli: mark test isolation as stable
2619f38 
This commit stabilizes test isolation configuration in the
test runner.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Dec 17, 2024
cjihrig
cjihrig commented Dec 17, 2024
View reviewed changes
doc/api/cli.md Outdated Show resolved Hide resolved
@cjihrig cjihrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64093/

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (a73c41c) to head (f360087).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/node_options.cc 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56298      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.01%     
==========================================
  Files         657      657              
  Lines      190290   190290              
  Branches    36533    36536       +3     
==========================================
- Hits       168488   168478      -10     
+ Misses      14984    14976       -8     
- Partials     6818     6836      +18
Files with missing lines Coverage Δ
lib/internal/test_runner/utils.js 56.20% <100.00%> (ø)
src/node_options.cc 87.98% <50.00%> (ø)

... and 30 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjihrig @nodejs-github-bot @anonrig