-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: workaround clang-3.4 ICE #8343
Conversation
Is there already an upstream bug fix or at least an upstream issue for this that might be worth linking to also? |
I don't have an upstream bug fix link, but the issue seems to be fixed in clang-3.4.2. As per #8323 (comment), it is non-trivial to upgrade to clang-3.4.2 or newer on the wheezy & precise configurations. |
Aside from objecting to the ugliness of C++, this LGTM Green CI run @ https://ci.nodejs.org/job/node-test-commit/4862/ Most notably, clang 3.4.1 run @ https://ci.nodejs.org/job/node-test-commit-linux/4917/nodes=ubuntu1204-clang341-64/ |
e926bbd
to
dc33d15
Compare
I have retargeted this PR to master (from v6.x) now that we have a (broken) CI builder for clang-3.4. New CI: https://ci.nodejs.org/job/node-test-pull-request/3911/ |
CI is green (enough). Debian8 failure is Jenkins, I've updated and restarted that node. OSX failure is known flaky (#4629). clang 4.3.1 is 👍 lgtm still |
PR-URL: nodejs#8343 Fixes: nodejs#8323 Reviewed-By: rvagg - Rod Vagg <[email protected]>
dc33d15
to
870faee
Compare
Thanks landed as 870faee. |
PR-URL: nodejs#8343 Fixes: nodejs#8323 Reviewed-By: rvagg - Rod Vagg <[email protected]>
PR-URL: #8343 Fixes: #8323 Reviewed-By: rvagg - Rod Vagg <[email protected]>
Ref: nodejs#8343 Fixes: nodejs#8323 PR-URL: nodejs#8317 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Ref: #8343 Fixes: #8323 PR-URL: #8317 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Ref: nodejs#8343 Fixes: nodejs#8323 PR-URL: nodejs#8317 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Fixes: nodejs#8323 Refs: nodejs#8343 Refs: nodejs#8317 PR-URL: nodejs#11029 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Fixes: nodejs#8323 Refs: nodejs#8343 Refs: nodejs#8317 PR-URL: nodejs#11029 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
deps: v8
Description of change
Work around internal compiler error with clang-3.4.
R=@nodejs/v8
/cc @chrislea
Fixes: #8323
EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/3893/
EDIT: V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/293/