Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.0.0 Proposal #9099

Closed
wants to merge 1 commit into from
Closed

v7.0.0 Proposal #9099

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 14, 2016

  • Buffer
    • Passing invalid input to Buffer.byteLength will now throw an error #8946.
    • Calling Buffer without new is now deprecated and will emit a process warning #8169.
    • Passing a negative number to allocUnsafe will now throw an error #7079.
  • Child Process
    • The fork and execFile methods now have stronger argument validation #7399.
  • Cluster
    • The worker.suicide method is deprecated and will emit a process warning #3747.
  • Deps
    • V8 has been updated to 5.4.500.31 #8852.
    • NODE_MODULE_VERSION has been updated to 51 #8808.
  • File System
    • A process warning is emitted if a callback is not passed to async file system methods #7897.
  • Intl
    • Intl.v8BreakIterator constructor has been deprecated and will emit a process warning #8908.
  • Promises
    • Unhandled Promise rejections have been deprecated and will emit a process warning #8217.
  • Punycode
    • The punycode module has been deprecated #7941.
  • URL
    • An Experimental WHATWG URL Parser has been introduced #7448.

@jasnell jasnell added the meta Issues and PRs related to the general management of the project. label Oct 14, 2016
@jasnell jasnell added this to the 7.0.0 milestone Oct 14, 2016
@targos
Copy link
Member

targos commented Oct 14, 2016

Copying over my comment from #8503 (comment):

I have a draft of a document explaining the new features and performance improvements that are coming with V8 5.4: https://gist.github.com/targos/eda0bd7068e38b5ece5802aaefa6e601

I don't know if this should be in the changelog, on a blog post or something else ?

@jasnell
Copy link
Member Author

jasnell commented Oct 14, 2016

Likely will include a short statement in the changelog but will provide more detail in a blog post

@jasnell jasnell force-pushed the v7.0.0-proposal branch 2 times, most recently from 49a4da7 to 1e03c09 Compare October 17, 2016 16:51
* [[`07dbf7313d`](https://github.com/nodejs/node/commit/07dbf7313d)] - **(SEMVER-MAJOR)** **promise**: hard deprecation for unhandled promise rejection (James M Snell) [#8217](https://github.com/nodejs/node/pull/8217)
* [[`ecf474ceba`](https://github.com/nodejs/node/commit/ecf474ceba)] - **(SEMVER-MAJOR)** **promise**: warn on unhandled rejections (Benjamin Gruenbaum) [#8217](https://github.com/nodejs/node/pull/8217)
* [[`1a9e247c79`](https://github.com/nodejs/node/commit/1a9e247c79)] - **(SEMVER-MAJOR)** **readline**: show completions only after 2nd TAB (Anna Henningsen) [#7754](https://github.com/nodejs/node/pull/7754)
* [[8a87b29034](https://github.com/nodejs/node/commit/8a87b29034)]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this commit ID is missing back ticks, i.e. should be 8a87b29034

@jasnell
Copy link
Member Author

jasnell commented Oct 18, 2016

Beta build run: https://ci-release.nodejs.org/job/iojs+release/1272/
This will be the final beta. The plan is to cut the first release candidate on Thursday, followed by a second release candidate as necessary on Monday, with the release targeted for Tuesday, October 25

@jasnell
Copy link
Member Author

jasnell commented Oct 19, 2016

Beta build artifacts are here: https://nodejs.org/download/test/v7.0.0-test201610180ccb98695e/
This build includes the release bit flipped as this is the final build before the actual release. This is only intended for a final round of testing. The first release candidate should arrive on Thursday.

/cc @nodejs/testing @nodejs/build

@jbergstroem
Copy link
Member

I'm going to proceed with nodejs/build#500 ahead of Thursday unless anyone has any objections.

@rvagg
Copy link
Member

rvagg commented Oct 19, 2016

@jasnell would you mind rebasing and editing one of my commits that didn't get metadata on master:

    tools: explicitly set digest algo for SHASUM to 256

should have

    PR-URL: https://github.com/nodejs/node/pull/9071
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>

I've done this on v4.x-staging

@rvagg
Copy link
Member

rvagg commented Oct 19, 2016

@jasnell I've cherry-picked these into v7.x-staging, they were the relevant security updates that went into v6.9.0 that belong here too:

  • cae9eb3 crypto: fix openssl.cnf FIPS handling & testing
  • 1ea0358 node: --openssl-config cli argument
  • 647afe9 inspector: generate UUID for debug targets

@jasnell
Copy link
Member Author

jasnell commented Oct 19, 2016

@nodejs/ctc @nodejs/collaborators ... v7.0.0 is almost ready to go. Please take a moment to look over the changelog and let me know if anything looks amiss or should be called out in the notable changes.

@jasnell
Copy link
Member Author

jasnell commented Oct 19, 2016

@rvagg ... I fixed that commit and pulled in the security fixes.

@jasnell
Copy link
Member Author

jasnell commented Oct 19, 2016

@silverwind
Copy link
Contributor

Probably not relevant to the release, but those hash links in your initial post don't work.

@benjamingr
Copy link
Member

I'd like to change the wording on unhandled promise rejections.

A few members of the promises community have concerns about that wording and I tend to agree.

Can we go with "promise rejections not handled within the same tick will now emit a warning on the process object unless an "unhandledRejection" event handler is installed"?

@targos
Copy link
Member

targos commented Oct 19, 2016

I'd also add a reference to #8317 in the V8 update line. 5.4.500.31 was minor.

@rvagg
Copy link
Member

rvagg commented Oct 19, 2016

@benjamingr if you think the wording on the post(s) at nodejs.org and/or in the changelogs could be improved around that then just file a pull request to adjust it.

@jasnell jasnell force-pushed the v7.0.0-proposal branch 2 times, most recently from 8030bf8 to eb919eb Compare October 20, 2016 16:44
@jbergstroem
Copy link
Member

sunos builds should now show up as smartos.

@jasnell
Copy link
Member Author

jasnell commented Oct 20, 2016

@nodejs/collaborators ... all, I'm going to be kicking off the first release candidate build in a couple of minutes. This means that after this point, unless the CTC deems it absolutely necessary, I won't be landing any more semver-minor or semver-major commits into v7.0.0. The second RC build will go out on Monday.

@jasnell
Copy link
Member Author

jasnell commented Oct 20, 2016

RC.1 Build: https://ci-release.nodejs.org/job/iojs+release/1283/ (cancelled)
RC.1 Build: https://ci-release.nodejs.org/job/iojs+release/1285/ (argh! failed because I didn't wait long enough before kicking it off.... will try again shortly)
RC.1 Build (third time's the charm): https://ci-release.nodejs.org/job/iojs+release/1286/
Nope, that one hiccuped also... number 4: https://ci-release.nodejs.org/job/iojs+release/1287/

Looks like there's some issues with the release job... waiting until those are resolved before continuing...

alright... finally got a good one... almost done: https://ci-release.nodejs.org/job/iojs+release/1289/

@nodejs/testing RC.1 artifacts are here: https://nodejs.org/download/rc/v7.0.0-rc.1/

@jasnell
Copy link
Member Author

jasnell commented Oct 24, 2016

Will be landing #9253 soon and will be wrapping this up and putting a bow on it. Will do the actual release build tonight and will promote in the morning.

@seishun
Copy link
Contributor

seishun commented Oct 24, 2016

Could we still get the libuv upgrade in? /cc @cjihrig

@jasnell
Copy link
Member Author

jasnell commented Oct 24, 2016

It's a bit too late for that, I'm afraid, There's no time to adequately test it. My plan is to do a quick spin around on a v7.1 next week to get the libuv and icu updates in

Notable Changes:

* Buffer
  * Passing invalid input to Buffer.byteLength will now throw an error [nodejs#8946](nodejs#8946).
  * Calling Buffer without new is now deprecated and will emit a process warning [nodejs#8169](nodejs#8169).
  * Passing a negative number to allocUnsafe will now throw an error [nodejs#7079](nodejs#7079).
* Child Process
  * The fork and execFile methods now have stronger argument validation [nodejs#7399](nodejs#7399).
* Cluster
  * The worker.suicide method is deprecated and will emit a process warning [nodejs#3747](nodejs#3747).
* Deps
  * V8 has been updated to 5.4.500.36 [nodejs#8317](nodejs#8317), [nodejs#8852](nodejs#8852), [nodejs#9253](nodejs#9253).
  * NODE_MODULE_VERSION has been updated to 51 [nodejs#8808](nodejs#8808).
* File System
  * A process warning is emitted if a callback is not passed to async file system methods [nodejs#7897](nodejs#7897).
* Intl
  * Intl.v8BreakIterator constructor has been deprecated and will emit a process warning [nodejs#8908](nodejs#8908).
* Promises
  * Unhandled Promise rejections have been deprecated and will emit a process warning [nodejs#8217](nodejs#8217).
* Punycode
  * The `punycode` module has been deprecated [nodejs#7941](nodejs#7941).
* URL
  * An Experimental WHATWG URL Parser has been introduced [nodejs#7448](nodejs#7448).
@jasnell
Copy link
Member Author

jasnell commented Oct 24, 2016

@jasnell
Copy link
Member Author

jasnell commented Oct 24, 2016

RC.2 test artifacts are here: https://nodejs.org/download/rc/v7.0.0-rc.2/

@jbergstroem
Copy link
Member

just a fyi: ran into issues renaming smartos for rc1; will do another attempt soon.

@jasnell jasnell changed the title v7.0.0 Proposal (Actual) v7.0.0 Proposal Oct 25, 2016
jasnell added a commit that referenced this pull request Oct 25, 2016
Notable Changes:

* Buffer
  * Passing invalid input to Buffer.byteLength will now throw an error [#8946](#8946).
  * Calling Buffer without new is now deprecated and will emit a process warning [#8169](#8169).
  * Passing a negative number to allocUnsafe will now throw an error [#7079](#7079).
* Child Process
  * The fork and execFile methods now have stronger argument validation [#7399](#7399).
* Cluster
  * The worker.suicide method is deprecated and will emit a process warning [#3747](#3747).
* Deps
  * V8 has been updated to 5.4.500.36 [#8317](#8317), [#8852](#8852), [#9253](#9253).
  * NODE_MODULE_VERSION has been updated to 51 [#8808](#8808).
* File System
  * A process warning is emitted if a callback is not passed to async file system methods [#7897](#7897).
* Intl
  * Intl.v8BreakIterator constructor has been deprecated and will emit a process warning [#8908](#8908).
* Promises
  * Unhandled Promise rejections have been deprecated and will emit a process warning [#8217](#8217).
* Punycode
  * The `punycode` module has been deprecated [#7941](#7941).
* URL
  * An Experimental WHATWG URL Parser has been introduced [#7448](#7448).

PR-URL: #9099
@jasnell
Copy link
Member Author

jasnell commented Oct 25, 2016

Release build is underway

jasnell added a commit that referenced this pull request Oct 25, 2016
jasnell added a commit that referenced this pull request Oct 25, 2016
Notable Changes:

* Buffer
  * Passing invalid input to Buffer.byteLength will now throw an error [#8946](#8946).
  * Calling Buffer without new is now deprecated and will emit a process warning [#8169](#8169).
  * Passing a negative number to allocUnsafe will now throw an error [#7079](#7079).
* Child Process
  * The fork and execFile methods now have stronger argument validation [#7399](#7399).
* Cluster
  * The worker.suicide method is deprecated and will emit a process warning [#3747](#3747).
* Deps
  * V8 has been updated to 5.4.500.36 [#8317](#8317), [#8852](#8852), [#9253](#9253).
  * NODE_MODULE_VERSION has been updated to 51 [#8808](#8808).
* File System
  * A process warning is emitted if a callback is not passed to async file system methods [#7897](#7897).
* Intl
  * Intl.v8BreakIterator constructor has been deprecated and will emit a process warning [#8908](#8908).
* Promises
  * Unhandled Promise rejections have been deprecated and will emit a process warning [#8217](#8217).
* Punycode
  * The `punycode` module has been deprecated [#7941](#7941).
* URL
  * An Experimental WHATWG URL Parser has been introduced [#7448](#7448).

PR-URL: #9099
jasnell added a commit to nodejs/nodejs.org that referenced this pull request Oct 25, 2016
jasnell added a commit to nodejs/nodejs.org that referenced this pull request Oct 25, 2016
@jasnell
Copy link
Member Author

jasnell commented Oct 25, 2016

merged. just waiting on the website to refresh now!

@jasnell jasnell closed this Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants