Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: news title -> blog #6183

Merged
merged 2 commits into from
Dec 17, 2023
Merged

fix: news title -> blog #6183

merged 2 commits into from
Dec 17, 2023

Conversation

AugustinMauroy
Copy link
Member

Description

Adjust the text in the header and the title on the page

Validation

It's should correct 😊

Related Issues

No Related issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • NA I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner December 13, 2023 09:29
Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 9:34am

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 16, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 98 🟢 93 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/blog 🟢 100 🟢 95 🟢 92 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
86.91% (392/451) 73.04% (103/141) 80.45% (70/87)

Unit Test Report

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 4.315s ⏱️

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorta ambivalent about these changes, but not enough to ask for changes. "Blog from 2023" does not sound better than "News from 2023" to me. Agree with the index.md change, as the nav item also recently changed, but not so sure on the other changes.

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Dec 17, 2023
Merged via the queue into main with commit 0b465f1 Dec 17, 2023
12 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the fix-news-title branch December 17, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants