Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated a string in array of code example #7402

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

AjayBains
Copy link
Contributor

Description

This PR updates a string in the code example given at the end of the page output-to-the-command-line-using-nodejs.

Found it while trying to learn.

Screenshot 2025-01-11 at 2 52 31 PM

running the above code doesn't works due to improper string

Screenshot 2025-01-11 at 4 46 34 PM

fixed it to

Screenshot 2025-01-11 at 4 50 01 PM

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.

@AjayBains AjayBains requested a review from a team as a code owner January 11, 2025 11:22
Copy link

vercel bot commented Jan 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jan 11, 2025 11:24am

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ! Thanks for your first contribution 🎉

Copy link
Contributor

github-actions bot commented Jan 11, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 88%
87.51% (736/841) 74.14% (238/321) 86.58% (142/164)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 5.705s ⏱️

@mikeesto mikeesto added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@mikeesto
Copy link
Member

There's a current incident with git operations/actions. Will try to land this later

@mikeesto mikeesto added this pull request to the merge queue Jan 14, 2025
Merged via the queue into nodejs:main with commit 68f6154 Jan 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants