Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run.md #7466

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Update run.md #7466

merged 1 commit into from
Feb 11, 2025

Conversation

justnixx
Copy link
Contributor

@justnixx justnixx commented Feb 2, 2025

Description

This PR updates the documentation to clarify that ts-node performs type checking by default unless transpileOnly is enabled.

The previous documentation suggested that ts-node does not perform type checking. However, testing confirms that it does type checking unless transpileOnly is explicitly enabled.

Validation

// example.ts
let username: string;
username = 22; // Type error

Running ts-node example.ts results in:

TSError: ⨯ Unable to compile TypeScript:
example.ts:3:1 - error TS2322: Type 'number' is not assignable to type 'string'.

ts-node -v output:

v10.9.2

This confirms that ts-node performs type checking by default in this version.

This PR updates the documentation to clarify that `ts-node` performs type checking by default unless `transpileOnly` is enabled.

Signed-off-by: ℵi✗✗ <[email protected]>
@justnixx justnixx requested a review from a team as a code owner February 2, 2025 21:23
Copy link

vercel bot commented Feb 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Feb 2, 2025 9:24pm

@AugustinMauroy
Copy link
Member

what is the pref cost of this ts-node feature ? if it's affect pref we should mention it

@justnixx
Copy link
Contributor Author

justnixx commented Feb 3, 2025 via email

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although this content should be updated -- cc @marco-ippolito

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 92 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
88.71% (739/833) 75.94% (240/316) 87.65% (142/162)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 5.417s ⏱️

@ovflowd ovflowd merged commit c474e82 into nodejs:main Feb 11, 2025
14 of 16 checks passed
@smith558
Copy link

smith558 commented Feb 11, 2025

@ovflowd reminder, code review comments in progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants