Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added Typescript support #99

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Added Typescript support #99

wants to merge 2 commits into from
+18 −0

Conversation

james-pre
Copy link

@james-pre james-pre commented Aug 4, 2024 •
edited
Loading

Adds support for Typescript by adding a declaration for the API.

Fixes #98

@james-pre james-pre changed the title Added Typescript support fix: Added Typescript support Aug 4, 2024
@james-pre
Copy link
Author

@dsanders11 @jviotti @robertgzr Could you please take a look at this PR?

jasongwartz
jasongwartz reviewed Aug 26, 2024
View reviewed changes
src/api.d.ts Outdated Show resolved Hide resolved
@james-pre
Copy link
Author

Thanks for the review. I've made the change.

@james-pre james-pre requested a review from jasongwartz August 26, 2024 14:28
jasongwartz
jasongwartz approved these changes Aug 26, 2024
View reviewed changes
Copy link

@jasongwartz jasongwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer, just a fellow user - but I've tried out this change locally and it has worked for me, would be very useful to have merged! 🙏

@james-pre
Copy link
Author

@jviotti @robertgzr @dsanders11,

Could you please take a look at this PR? It's been over 3 weeks since it was opened.

jviotti
jviotti approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much cycles for Postject right now, but looks OK

@james-pre
Copy link
Author

It appears that the CI tests did not run. Could a maintainer please take a look? Thanks.

@dsanders11 @jviotti @robertgzr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasongwartz jasongwartz jasongwartz approved these changes

@jviotti jviotti jviotti approved these changes

@dsanders11 dsanders11 Awaiting requested review from dsanders11 dsanders11 is a code owner

@robertgzr robertgzr Awaiting requested review from robertgzr robertgzr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Types/Typescript support
3 participants
@james-pre @jviotti @jasongwartz