Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch: implement forbidden request header #3695

Closed
wants to merge 1 commit into from
Closed

fetch: implement forbidden request header #3695

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 7, 2024

This relates to...

Fetch specification https://fetch.spec.whatwg.org/#forbidden-request-header

Changes

Implements forbidden header names in fetch specification

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

mcollina
mcollina requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually doing it on purpose and deviating from the spec. A server-side fetch unable to pass all kinds of headers around is not useful. What we do now matches the behavior of Deno and historically of node-fetch.

@trivikr trivikr closed this Oct 7, 2024
@trivikr trivikr mentioned this pull request Oct 7, 2024
Open
7 tasks
@trivikr
Copy link
Member Author

trivikr commented Oct 7, 2024

Created new PR to document the reasoning in comments #3696

@trivikr trivikr deleted the request-forbidden-headers branch October 7, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivikr @mcollina