Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add setter to sqlite cache store #4012

Closed
wants to merge 1 commit into from
Closed

feat: add setter to sqlite cache store #4012

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jan 18, 2025

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@ronag ronag requested a review from mcollina January 18, 2025 13:48
@ronag ronag force-pushed the sql-set branch 2 times, most recently from d6fd36f to 4be2eb7 Compare January 18, 2025 13:58
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, shall we add some testing around it?

@ronag
Copy link
Member Author

ronag commented Jan 20, 2025

lgtm, shall we add some testing around it?

It's kind of indirectly tested through createWriteStream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants