-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing optional parameter restart
to tmr:start()
#3111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits; otherwise LGTM.
Lukas, I tidied up |
Of course not. Go ahead. |
5c85a90
to
3281eaa
Compare
Oups. A bit of fight with @marcelstoer in commits. I hope the result is fine. |
As #1168 is now closed we maybe shouldn't argue about it but replacing spaces with tabs is a move in the wrong direction IMO. I'm happy to merge this though. |
spaces -> tabs - I only made it consistent with the rest of the file where tabs are used. |
Fixes #3020.
dev
branch rather than formaster
.docs/*
.Implements the solution discussed in #3020 as wrapped up by @HHHartmann
Also removes unecessary check of lua_newuserdata result (also in ads1115 module).