chore: remove foreign call handler logic from compiler #6664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
…compiler * master: chore: update noir-bench-report version (#6675) fix: Prevent hoisting binary instructions which can overflow (#6672) feat(ssa): Hoisting of array get using known induction variable maximum (#6639) feat: better error message when trying to invoke struct function field (#6661) feat: add memory report into the CI (#6630) feat: allow ignoring test failures from foreign calls (#6660) chore: refactor foreign call executors (#6659) fix: correct signed integer handling in `noirc_abi` (#6638) fix: allow multiple `_` parameters, and disallow `_` as an expression you can read from (#6657) feat: allow filtering which SSA passes are printed (#6636) fix: use correct type for attribute arguments (#6640) fix: always return an array of `u8`s when simplifying `Intrinsic::ToRadix` calls (#6663) feat(ssa): Option to set the maximum acceptable Brillig bytecode increase in unrolling (#6641)
Peak Memory Sample
|
|
I've managed to break the part of the printing logic where we split up the params here. Parking for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
There's some pretty horrific abstraction leaks which got added at some point a load of foreign call logic has been pushed into the compiler. This PR goes some of the way towards unpicking that.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.