chore: add script to check for critical libraries supporting a given Noir version #6697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peak Memory Sample
|
Savio-Sou
reviewed
Dec 4, 2024
Co-authored-by: Savio <[email protected]>
TomAFrench
commented
Dec 4, 2024
TomAFrench
added
the
run-external-checks
aakoshh
reviewed
Dec 5, 2024
aakoshh
reviewed
Dec 5, 2024
Co-authored-by: Akosh Farkash <[email protected]>
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 7, 2024
…#6650) fix: git dependency trailing slash (noir-lang/noir#6725) chore: optimise older opcodes in reverse order (noir-lang/noir#6476) chore: add script to check for critical libraries supporting a given Noir version (noir-lang/noir#6697) fix!: several format string fixes and improvements (noir-lang/noir#6703) fix: print ssa blocks without recursion (noir-lang/noir#6715) chore: redo typo PR by Madmaxs2 (noir-lang/noir#6721) chore: add a few regression tests for #6674 (noir-lang/noir#6687)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 7, 2024
fix: git dependency trailing slash (noir-lang/noir#6725) chore: optimise older opcodes in reverse order (noir-lang/noir#6476) chore: add script to check for critical libraries supporting a given Noir version (noir-lang/noir#6697) fix!: several format string fixes and improvements (noir-lang/noir#6703) fix: print ssa blocks without recursion (noir-lang/noir#6715) chore: redo typo PR by Madmaxs2 (noir-lang/noir#6721) chore: add a few regression tests for #6674 (noir-lang/noir#6687)
This was referenced Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This script is intended to make the lives of @kashbrti,@jtriley-eth and @Savio-Sou easier when it comes to giving a green light for marking a noir release as stable.
CRITICAL_NOIR_LIBRARIEScontains a list of URLs for all the noir repos we consider to be required to work with a given noir release. Running./scripts/check-critical-libraries.sh NOIR_VERSIONwill download the latest release of all of the critical libraries and run their test suites with the given version of nargo.Additional Context
Currently this script fails on:
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.