-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nargo test -q
(or nargo test --format terse
)
#6776
Draft
asterite
wants to merge
40
commits into
master
Choose a base branch
from
ab/nargo-test-machine-readable-output
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom French <[email protected]>
It seems `max_num_threads` is how many threads in theory Rayon could spawn, which was 2**16 on my machine. `current_num_threads` is the recommended number of threads to use, which is 10 on my machine.
Compilation Sample
|
Peak Memory Sample
|
asterite
force-pushed
the
ab/nargo-test-machine-readable-output
branch
from
December 11, 2024 19:59
a4d7df8
to
94aabde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptio
Made on top of #6728
Problem
Towards #6733
Summary
Eventually we'll have
nargo test --format json
, which is what #6733. As a first step I wanted to introduce theformat
flag and, to try that abstraction in code I introduced a terse formatter similar to Rust.On failure we don't immediately print the error. Instead, it's printed at the end (like in Rust). I can imagine this could be used in CI to reduce the output verboseness, because I guess all that matters in CI is seeing which tests failed.
Like in Rust, there are two ways to trigger this terse behavior:
-q
(or--quiet
) or--format terse
. We could just keep--format terse
but I think-q
is convenient (andformat
is more general as it will soon supportjson
).Here's the output when all tests pass:
Additional Context
It would be nice to get rid of those "proptest" messages but I don't know why they happen.
Documentation
Check one:
PR Checklist
cargo fmt
on default settings.