Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update memory report to run noir-contracts repo #6809

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vezenovm
Copy link
Contributor

Description

Problem*

No issue

Summary*

I just saw #6807 and noticed that ram_blowup_regression went down by 50%. I remembered that this is a pattern common in the noir contracts so I want to test bringing back the noir-contracts repo to the memory report. Previously it took just under 30 minutes and had a peak memory of ~9 GB.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Compilation Sample

Program Compilation Time %
sha256_regression 0m1.513s 3%
regression_4709 0m0.772s -3%
ram_blowup_regression 0m16.308s -1%
rollup-base-public 6m27.024s 31%
rollup-base-private 3m16.001s 0%
private-kernel-tail 0m1.224s -13%
private-kernel-reset 0m9.073s 2%
private-kernel-inner 0m3.048s 20%
parity-root 0m1.008s 2%
noir-contracts 2m51.395s -1%

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Peak Memory Sample

Program Peak Memory %
keccak256 78.71M 0%
workspace 121.96M -1%
regression_4709 286.66M 0%
ram_blowup_regression 1.62G 0%
private-kernel-tail 209.11M 0%
private-kernel-reset 848.11M 0%
private-kernel-inner 304.33M 0%
parity-root 174.64M 0%

@vezenovm
Copy link
Contributor Author

Ok looks like the noir-contracts memory report still did not finish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant