Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Resolve enums & prepare type system #7115

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jan 17, 2025

Description

Problem*

Working towards #988

Summary*

  • Implements def_collector::collect_enums
  • Lays down some prep work in the type system for enums. The most significant of which (and the majority of the diff) is changing StructType to DataType to handle structs and enums. Similarly StructId is now TypeId, although I'm leaving metaprogramming changes for a future date (we can abstract these changes there or impose the same merger).
  • Implements some missing language server integration

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher
Copy link
Contributor Author

jfecher commented Jan 17, 2025

Currently failing due to the NestedSlice error now failing because it's now catching that we're trying to get the fields of a type which still hasn't had it's fields set yet. This was the case before too but we previously just returned an empty vec of fields.

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Compilation Memory Report

Program Peak Memory %
keccak256 43.150 -45%
workspace 60.380 -52%
regression_4709 99.040 -77%
ram_blowup_regression 43.190 -98%
rollup-root 92.330 -85%
rollup-merge 92.330 -82%
rollup-block-root-single-tx 92.330 -100%
rollup-block-root-empty 92.330 -82%
rollup-block-root 92.330 -100%
rollup-block-merge 92.330 -85%
rollup-base-public 92.330 -97%
rollup-base-private 92.330 -92%
private-kernel-tail 75.710 -64%
private-kernel-reset 75.750 -88%
private-kernel-inner 75.720 -75%

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Execution Memory Report

Program Peak Memory %
keccak256 43.150 -42%
workspace 61.200 -51%
regression_4709 99.040 -69%
ram_blowup_regression 43.190 -92%
rollup-root 92.330 -82%
rollup-merge 92.330 -81%
rollup-block-root 92.330 -93%
rollup-block-merge 92.330 -82%
rollup-base-public 92.330 -88%
rollup-base-private 92.340 -85%
private-kernel-tail 75.710 -59%
private-kernel-reset 75.750 -70%
private-kernel-inner 75.720 -64%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant