Use the automatic caching by setup-go and fix staticcheck caching (op…

…enconfig#1989)

* Run static_analysis on main branch

* trigger build to test caching

.github/workflows/go.yml

@@ -47,3 +47,54 @@ jobs:
         uses: shogo82148/actions-goveralls@v1
         with:
           path-to-profile: profile.cov
+
+  static_analysis:
+    name: Static Analysis
+    runs-on: ubuntu-latest
+    steps:
+    - name: Install go
+      uses: actions/setup-go@v2
+      with:
+        go-version: '1.19'
+    - name: Checkout code
+      uses: actions/checkout@v3
+    - name: Cache
+      uses: actions/cache@v2
+      with:
+        path: |
+          ~/go/pkg/mod
+          ~/.cache/go-build
+          ~/.cache/staticcheck
+        key: ${{ github.job }}-${{ runner.os }}-go-build-${{ hashFiles('**/go.sum') }}
+        restore-keys: ${{ github.job }}-${{ runner.os }}-go-build-
+    - name: Go vet
+      run: GOGC=30 go vet ./...
+    - name: Gofmt
+      run: |
+        # gofmt always returns true, so we use grep '^' which returns
+        # true on non-empty output, but will otherwise passthrough all
+        # output lines.
+        if gofmt -d -s . | grep '^'; then
+          exit 1
+        fi
+    - name: Get goimports
+      run: go install golang.org/x/tools/cmd/goimports@latest
+    - name: Goimports
+      run: |
+        # goimports always returns true, so we use grep '^' which returns
+        # true on non-empty output, but will otherwise passthrough all
+        # output lines.
+        #
+        # goimports does not support "gofmt -s" so both goimports and gofmt are
+        # required.
+        if goimports -d . | grep '^'; then
+          exit 1
+        fi
+    - name: Get revive
+      run: go install github.com/mgechev/revive@latest
+    - name: Run revive
+      run: revive ./...
+    - name: Get staticcheck
+      run: go install honnef.co/go/tools/cmd/staticcheck@latest
+    - name: Run staticcheck
+      run: GOGC=30 staticcheck ./...

.github/workflows/pull_request.yml

@@ -45,57 +45,6 @@ jobs:
           exit 1
         fi
 
-  static_analysis:
-    name: Static Analysis
-    runs-on: ubuntu-latest
-    steps:
-    - name: Install go
-      uses: actions/setup-go@v2
-      with:
-        go-version: '1.19'
-    - name: Checkout code
-      uses: actions/checkout@v3
-    - name: Cache
-      uses: actions/cache@v2
-      with:
-        path: |
-          ~/go/pkg/mod
-          ~/.cache/go-build
-          ~/.cache/staticcheck
-        key: ${{ github.job }}-${{ runner.os }}-go-build-${{ hashFiles('**/go.sum') }}
-        restore-keys: ${{ github.job }}-${{ runner.os }}-go-build-
-    - name: Go vet
-      run: GOGC=30 go vet ./...
-    - name: Gofmt
-      run: |
-        # gofmt always returns true, so we use grep '^' which returns
-        # true on non-empty output, but will otherwise passthrough all
-        # output lines.
-        if gofmt -d -s . | grep '^'; then
-          exit 1
-        fi
-    - name: Get goimports
-      run: go install golang.org/x/tools/cmd/goimports@latest
-    - name: Goimports
-      run: |
-        # goimports always returns true, so we use grep '^' which returns
-        # true on non-empty output, but will otherwise passthrough all
-        # output lines.
-        #
-        # goimports does not support "gofmt -s" so both goimports and gofmt are
-        # required.
-        if goimports -d . | grep '^'; then
-          exit 1
-        fi
-    - name: Get revive
-      run: go install github.com/mgechev/revive@latest
-    - name: Run revive
-      run: revive ./...
-    - name: Get staticcheck
-      run: go install honnef.co/go/tools/cmd/staticcheck@latest
-    - name: Run staticcheck
-      run: GOGC=30 staticcheck ./...
-
   otg_changes:
     name: OTG Changes Required
     runs-on: ubuntu-latest