Skip to content

Commit

Permalink
check whether n_primitive matches the lengths of exponents and contra…
Browse files Browse the repository at this point in the history
…ction coefficients
  • Loading branch information
EBB2675 committed Nov 20, 2024
1 parent 42f4f38 commit 0f92eb9
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion src/nomad_simulations/schema_packages/basis_set.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,19 @@ class AtomCenteredFunction(ArchiveSection):

def normalize(self, archive: 'EntryArchive', logger: 'BoundLogger') -> None:
super().normalize(archive, logger)
# self.name = self.m_def.name

# Validation: Check that n_primitive matches the lengths of exponents and contraction coefficients
if self.n_primitive is not None:
if len(self.exponents or []) != self.n_primitive:
logger.error(
f"Mismatch in number of exponents: expected {self.n_primitive}, "
f"found {len(self.exponents or [])}."
)
if len(self.contraction_coefficients or []) != self.n_primitive:
logger.error(
f"Mismatch in number of contraction coefficients: expected {self.n_primitive}, "
f"found {len(self.contraction_coefficients or [])}."
)


class AtomCenteredBasisSet(BasisSetComponent):
Expand Down

1 comment on commit 0f92eb9

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/nomad_simulations
   __init__.py4250%3–4
   _version.py11282%5–6
src/nomad_simulations/schema_packages
   __init__.py15287%39–41
   atoms_state.py1902189%13–15, 201–204, 228, 283–284, 352–353, 355, 537, 549–550, 611–615, 630–634, 641
   basis_set.py2553487%8–9, 122–133, 172–185, 244–254, 302, 483–487, 509–510, 554–557, 676, 707, 709
   general.py89891%4–7, 121, 185, 295–296, 306
   model_method.py2737971%10–12, 171–174, 177–184, 276–277, 297, 318–339, 355–381, 384–401, 587, 780, 791, 833–840, 878, 897, 977, 1034, 1109, 1223, 1236
   model_system.py3483789%45–51, 235, 254, 258, 261, 264, 290, 376–377, 454–455, 472–473, 686–689, 736–743, 917–918, 1140–1144, 1150–1151, 1159–1160, 1165, 1188
   numerical_settings.py2746477%12–14, 133, 204, 274, 276–277, 280–283, 287–288, 295–298, 307–310, 314–317, 319–322, 327–330, 336–339, 526–553, 628, 663–666, 690, 693, 738, 740–743, 747, 751, 798, 802–823, 878–879, 946, 968
   outputs.py1201092%9–10, 252–255, 295–298, 323, 325, 362, 381
   physical_property.py102793%20–22, 202, 331–333
   variables.py861286%8–10, 98, 121, 145, 167, 189, 211, 233, 256, 276
src/nomad_simulations/schema_packages/properties
   band_gap.py51590%8–10, 135–136
   band_structure.py1232580%9–11, 232–265, 278, 285, 321–322, 325, 372–373, 378
   energies.py42979%7–9, 36, 57, 82, 103, 119, 134
   fermi_surface.py17476%7–9, 40
   forces.py22673%7–9, 36, 56, 79
   greens_function.py991387%7–9, 210–211, 214, 235–236, 239, 260–261, 264, 400
   hopping_matrix.py29583%7–9, 58, 94
   permittivity.py48883%7–9, 97–105
   spectral_profile.py26012851%9–11, 57–60, 95–98, 199–300, 356–368, 393–396, 416, 421–424, 466–502, 526, 573–576, 592–593, 598–604
   thermodynamics.py752764%7–9, 35, 56, 72, 81, 90, 101, 110, 137, 147, 157, 172–174, 177, 193, 213–215, 218, 234, 254–256, 259
src/nomad_simulations/schema_packages/utils
   utils.py791680%8–11, 65–74, 83–84, 89, 92, 169–170
TOTAL262352480% 

Tests Skipped Failures Errors Time
402 0 💤 0 ❌ 0 🔥 5.973s ⏱️

Please sign in to comment.