Skip to content

Commit

Permalink
removed logger and unused typing
Browse files Browse the repository at this point in the history
  • Loading branch information
jrudz committed Jun 4, 2024
1 parent 2b8fe93 commit 712bd9a
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/nomad_simulations/general.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#

import numpy as np
from typing import List, Callable, Any
from typing import List
from structlog.stdlib import BoundLogger

from nomad.units import ureg
Expand Down Expand Up @@ -180,14 +180,13 @@ def _set_system_branch_depth(
self._set_system_branch_depth(system_child, branch_depth + 1)

def resolve_composition_formula(
self, system_parent: ModelSystem, logger: BoundLogger
self, system_parent: ModelSystem
) -> None:
"""Determine and set the composition formula for system_parent and all of its
descendants.
Args:
system_parent (ModelSystem): The upper-most level of the system hierarchy to consider.
logger (BoundLogger): The logger to log messages.
"""
def set_composition_formula(system: ModelSystem, subsystems: List[ModelSystem], atom_labels: List[str]) -> None:
"""Determines the composition formula for `system` based on its `subsystems`.
Expand Down Expand Up @@ -249,4 +248,4 @@ def normalize(self, archive, logger) -> None:

if is_not_representative(system_parent, logger):
continue
self.resolve_composition_formula(system_parent, logger)
self.resolve_composition_formula(system_parent)

0 comments on commit 712bd9a

Please sign in to comment.