Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ElectronicGreensFunction and ElectronicSelfEnergy properties #109

Conversation

JosePizarro3
Copy link
Collaborator

@JosePizarro3 JosePizarro3 commented Aug 26, 2024

Closes #55

Todo:

  • Add OrbitalDoubleOccupancy.

Added Time, ImaginaryTime, MatsubaraFrequency variables

Added info in description of hopping matrix
@JosePizarro3 JosePizarro3 linked an issue Aug 26, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Aug 27, 2024

Pull Request Test Coverage Report for Build 10574935543

Details

  • 120 of 139 (86.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 78.936%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nomad_simulations/schema_packages/properties/band_structure.py 9 12 75.0%
src/nomad_simulations/schema_packages/variables.py 18 21 85.71%
src/nomad_simulations/schema_packages/properties/greens_function.py 86 99 86.87%
Totals Coverage Status
Change from base Build 10525294235: 0.6%
Covered Lines: 1765
Relevant Lines: 2236

💛 - Coveralls

@JosePizarro3 JosePizarro3 merged commit 90c99bc into develop Aug 27, 2024
7 checks passed
@JosePizarro3 JosePizarro3 deleted the 55-add-electronicgreensfunction-and-electronicselfenergy-properties branch August 27, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ElectronicGreensFunction and ElectronicSelfEnergy properties
2 participants