Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine PhysicalProperty.value interface #146

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

ndaelman-hu
Copy link
Collaborator

Previously, PhysicalProperty.value was defined at the schema level, with its final shape being re-defined during __setattr__.
This limits certain strategies, e.g. MappingAnnotation, which add variables after setting value.

This PR moves the definition of PhysicalProperty.value as a whole to normalization time. The schema definition upon which value is built comes from _base_value.

@ndaelman-hu ndaelman-hu added bug Something isn't working improvement/fix Improvement or fix of a previous feature labels Nov 12, 2024
@ndaelman-hu ndaelman-hu self-assigned this Nov 12, 2024
@coveralls
Copy link

coveralls commented Nov 12, 2024

Pull Request Test Coverage Report for Build 11804702226

Details

  • 65 of 84 (77.38%) changed or added relevant lines in 10 files are covered.
  • 81 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-3.2%) to 76.929%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nomad_simulations/schema_packages/properties/band_gap.py 2 6 33.33%
src/nomad_simulations/schema_packages/properties/greens_function.py 10 14 71.43%
src/nomad_simulations/schema_packages/physical_property.py 35 46 76.09%
Files with Coverage Reduction New Missed Lines %
src/nomad_simulations/schema_packages/physical_property.py 1 83.33%
src/nomad_simulations/schema_packages/properties/band_gap.py 5 53.85%
src/nomad_simulations/schema_packages/properties/spectral_profile.py 12 43.03%
src/nomad_simulations/schema_packages/outputs.py 14 80.0%
src/nomad_simulations/schema_packages/properties/greens_function.py 17 69.14%
src/nomad_simulations/schema_packages/properties/band_structure.py 32 51.43%
Totals Coverage Status
Change from base Build 11661595489: -3.2%
Covered Lines: 1864
Relevant Lines: 2423

💛 - Coveralls

ndaelman added 4 commits November 12, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement/fix Improvement or fix of a previous feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants